linux-kernel - Re: [PATCH v2] uaccess: decouple INLINE_COPY_FROM_USER and CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <64e953b7-bec9-404c-88b6-b3febd238afc@app.fastmail.com>
Date: Fri, 24 Oct 2025 18:16:29 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Yury Norov" <yury.norov@...il.com>, "Miguel Ojeda" <ojeda@...nel.org>,
 "Andrew Morton" <akpm@...ux-foundation.org>,
 "Alice Ryhl" <aliceryhl@...gle.com>, "Boqun Feng" <boqun.feng@...il.com>,
 "Danilo Krummrich" <dakr@...nel.org>
Cc: "Alex Gaynor" <alex.gaynor@...il.com>, "Gary Guo" <gary@...yguo.net>,
 "John Hubbard" <jhubbard@...dia.com>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 "Benno Lossin" <lossin@...nel.org>,
 "Andreas Hindborg" <a.hindborg@...nel.org>,
 "Trevor Gross" <tmgross@...ch.edu>, linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v2] uaccess: decouple INLINE_COPY_FROM_USER and CONFIG_RUST

On Fri, Oct 24, 2025, at 17:47, Yury Norov (NVIDIA) wrote:
> Commit 1f9a8286bc0c ("uaccess: always export _copy_[from|to]_user with
> CONFIG_RUST") exports _copy_{from,to}_user() unconditionally, if RUST
> is enabled. This pollutes exported symbols namespace, and spreads RUST
> ifdefery in core files.
>
> It's better to declare a corresponding helper under the rust/helpers,
> similarly to how non-underscored copy_{from,to}_user() is handled.
>
> Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>
> Tested-by: Alice Ryhl <aliceryhl@...gle.com>
> Signed-off-by: Yury Norov (NVIDIA) <yury.norov@...il.com>

Acked-by: Arnd Bergmann <arnd@...db.de>