linux-kernel - Re: [PATCH] x86/mm: Unify __phys_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b650dc79-1dbb-48d8-bc92-cc468e807ad5@intel.com>
Date: Fri, 24 Oct 2025 10:06:08 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Brendan Jackman <jackmanb@...gle.com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
 Andy Lutomirski <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/mm: Unify __phys_addr_symbol()

On 8/13/25 08:08, Brendan Jackman wrote:
> There are two implementations on 64-bit, depending on
> CONFIG_DEBUG_VIRTUAL, but they differ only regarding the presence of
> VIRTUAL_BUG_ON, which is already ifdef'd on CONFIG_DEBUG_VIRTUAL.
> 
> To avoid adding a function call on non-LTO non-DEBUG_VIRTUAL builds,
> move the function into the header. (Note the function is already only
> used on 64-bit).

... and just for the record CONFIG_DEBUG_VIRTUAL really is a
debug-build-only thing. I don't see it set in any normal distro kernels.
This shouldn't bloat any normal builds, although it will probably make
CONFIG_DEBUG_VIRTUAL=y build bigger. But I don't think we care about that.

Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>