linux-kernel - Re: [PATCH v3 0/2] arm64: dts: rockchip: Add vdpu 381 and 383 nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DDQSO2HR1BFU.2JONNHRBR0LR5@cknow-tech.com>
Date: Fri, 24 Oct 2025 21:20:45 +0200
From: "Diederik de Haas" <diederik@...ow-tech.com>
To: "Detlev Casanova" <detlev.casanova@...labora.com>,
 <linux-kernel@...r.kernel.org>
Cc: "Heiko Stuebner" <heiko@...ech.de>, "Shawn Lin"
 <shawn.lin@...k-chips.com>, "Kever Yang" <kever.yang@...k-chips.com>,
 "Chukun Pan" <amadeus@....edu.cn>, "Alexander Shiyan"
 <eagle.alexander923@...il.com>, <kernel@...labora.com>, "Dragan Simic"
 <dsimic@...jaro.org>, "Rob Herring" <robh@...nel.org>, "Sebastian Reichel"
 <sebastian.reichel@...labora.com>, <linux-rockchip@...ts.infradead.org>,
 <devicetree@...r.kernel.org>, "Conor Dooley" <conor+dt@...nel.org>, "Damon
 Ding" <damon.ding@...k-chips.com>, "Chris Morgan"
 <macromorgan@...mail.com>, <linux-arm-kernel@...ts.infradead.org>, "Patrick
 Wildt" <patrick@...eri.se>, "Alexey Charkov" <alchark@...il.com>,
 "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Nicolas Frattaroli"
 <nicolas.frattaroli@...labora.com>, "Tomeu Vizoso" <tomeu@...euvizoso.net>
Subject: Re: [PATCH v3 0/2] arm64: dts: rockchip: Add vdpu 381 and 383 nodes

Hi Detlev,

On Mon Oct 20, 2025 at 11:20 PM CEST, Detlev Casanova wrote:
> Add the nodes for vdpu 381 and 383, respectively RK3588 and RK3576.
> To keep compatibility with older variants, the reg ranges order is not
> in register order so that the function reg range is kept first.

This is a great comment, which I'd have preferred to have seen in the
commit messages themselves.

Especially since I'm getting DTB validation warnings:

  DTC [C] arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb
arch/arm64/boot/dts/rockchip/rk3576.dtsi:1292.30-1314.5: Warning (simple_bus_reg):
/soc/video-codec@...00000: simple-bus unit address format error, expected "27b00100"
  DTC [C] arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dtb
arch/arm64/boot/dts/rockchip/rk3576.dtsi:1292.30-1314.5: Warning (simple_bus_reg):
/soc/video-codec@...00000: simple-bus unit address format error, expected "27b00100"


For some reason I'm not getting that for rk3588, which I need to
investigate further. Technically, I ran my DTB validation script on your
'add-vdpu381-and-383-to-rkvdec-v3-on-next' branch, but I don't see how
that would/could change the outcome.

My validation script does essentially this:
``make CHECK_DTBS=y W=1 $(get_my_dtbs)``

('get_my_dtbs' returns a list of dtb files I want to check)

So it looks like the DTB validation tool is not happy that the
reg ranges are not sorted in 'proper' order.

Note that the ``W=1`` is essential to see the warning, it does not show
up when ``W=0`` is used.
I'll leave it up to you and the maintainers to judge whether this is
problematic or not, but wanted to mention it.

Cheers,
  Diederik

> Also adds the corresponding iommu nodes.
>
> Note that on RK3588, both cores are added as it represents the hardware,
> but the driver, later will only register the first one.
>
> Regards,
> Detlev.
>
> Changes since v2:
>  - Set the correct IRQ number for the second rk3588 core
>
> Changes since v1:
>  - Set node name to match first reg range
>
> Detlev Casanova (2):
>   arm64: dts: rockchip: Add the vdpu381 Video Decoders on RK3588
>   arm64: dts: rockchip: Add the vdpu383 Video Decoder on rk3576
>
>  arch/arm64/boot/dts/rockchip/rk3576.dtsi      | 36 +++++++++
>  arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 74 +++++++++++++++++++
>  2 files changed, 110 insertions(+)