linux-kernel - Re: [PATCH] accel/amdxdna: Fix incorrect return value in aie2_hwctx_sync_debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b9eb27e-b178-cfc8-5591-f1fb4b0595d3@amd.com>
Date: Fri, 24 Oct 2025 13:09:23 -0700
From: Lizhi Hou <lizhi.hou@....com>
To: "Mario Limonciello (AMD) (kernel.org)" <superm1@...nel.org>,
	<ogabbay@...nel.org>, <quic_jhugo@...cinc.com>,
	<maciej.falkowski@...ux.intel.com>, <dan.carpenter@...aro.org>,
	<dri-devel@...ts.freedesktop.org>
CC: <linux-kernel@...r.kernel.org>, <max.zhen@....com>, <sonal.santan@....com>
Subject: Re: [PATCH] accel/amdxdna: Fix incorrect return value in
 aie2_hwctx_sync_debug_bo()

Applied to drm-misc-next.

On 10/24/25 11:06, Mario Limonciello (AMD) (kernel.org) wrote:
>
>
> On 10/24/2025 11:26 AM, Lizhi Hou wrote:
>> When the driver issues the SYNC_DEBUG_BO command, it currently returns 0
>> even if the firmware fails to execute the command. Update the driver to
>> return -EINVAL in this case to properly indicate the failure.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
>> Closes: 
>> https://lore.kernel.org/dri-devel/aPsadTBXunUSBByV@stanley.mountain/
>> Fixes: 7ea046838021 ("accel/amdxdna: Support firmware debug buffer")
>> Signed-off-by: Lizhi Hou <lizhi.hou@....com>
> Reviewed-by: Mario Limonciello (AMD) <superm1@...nel.org>> ---
>>   drivers/accel/amdxdna/aie2_ctx.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/accel/amdxdna/aie2_ctx.c 
>> b/drivers/accel/amdxdna/aie2_ctx.c
>> index 63450b7773ac..c6c473c78352 100644
>> --- a/drivers/accel/amdxdna/aie2_ctx.c
>> +++ b/drivers/accel/amdxdna/aie2_ctx.c
>> @@ -879,7 +879,7 @@ int aie2_hwctx_sync_debug_bo(struct amdxdna_hwctx 
>> *hwctx, u32 debug_bo_hdl)
>>       aie2_cmd_wait(hwctx, seq);
>>       if (cmd.result) {
>>           XDNA_ERR(xdna, "Response failure 0x%x", cmd.result);
>> -        return ret;
>> +        return -EINVAL;
>>       }
>>         return 0;
>