linux-kernel - Re: [PATCH v1 1/1] x86/bugs: Remove dead code which might prevent from building

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251024222717.sgmqfpyas3gekgqf@desk>
Date: Fri, 24 Oct 2025 15:27:17 -0700
From: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: "Borislav Petkov (AMD)" <bp@...en8.de>,
	David Kaplan <david.kaplan@....com>, linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev, Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH v1 1/1] x86/bugs: Remove dead code which might prevent
 from building

On Fri, Oct 24, 2025 at 02:59:59PM +0200, Andy Shevchenko wrote:
> Clang, in particular, is not happy about dead code:
> 
> arch/x86/kernel/cpu/bugs.c:1830:20: error: unused function 'match_option' [-Werror,-Wunused-function]
>  1830 | static inline bool match_option(const char *arg, int arglen, const char *opt)
>       |                    ^~~~~~~~~~~~
> 1 error generated.
> 
> Remove a leftover from the previous cleanup.
> 
> Fixes: 02ac6cc8c5a1 ("x86/bugs: Simplify SSB cmdline parsing")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  arch/x86/kernel/cpu/bugs.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c
> index e08de5b0d20b..d7fa03bf51b4 100644
> --- a/arch/x86/kernel/cpu/bugs.c
> +++ b/arch/x86/kernel/cpu/bugs.c
> @@ -1827,13 +1827,6 @@ void unpriv_ebpf_notify(int new_state)
>  }
>  #endif
>  
> -static inline bool match_option(const char *arg, int arglen, const char *opt)
> -{
> -	int len = strlen(opt);
> -
> -	return len == arglen && !strncmp(arg, opt, len);
> -}

Reviewed-by: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>