linux-kernel - Re: [PATCH] firewire: core: fix __must

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251024232921.GA463024@workstation.local>
Date: Sat, 25 Oct 2025 08:29:21 +0900
From: Takashi Sakamoto <o-takashi@...amocchi.jp>
To: linux1394-devel@...ts.sourceforge.net
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firewire: core: fix __must_hold() annotation

On Thu, Oct 23, 2025 at 07:43:49PM +0900, Takashi Sakamoto wrote:
> The variable name passed to __must_hold() annotation is invalid.
> 
> This commit fixes it.
> 
> Fixes: 420bd7068cbf ("firewire: core: use spin lock specific to transaction")
> Signed-off-by: Takashi Sakamoto <o-takashi@...amocchi.jp>
> ---
>  drivers/firewire/core-transaction.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firewire/core-transaction.c b/drivers/firewire/core-transaction.c
> index dd3656a0c1ff..c65f491c54d0 100644
> --- a/drivers/firewire/core-transaction.c
> +++ b/drivers/firewire/core-transaction.c
> @@ -269,7 +269,7 @@ static void fw_fill_request(struct fw_packet *packet, int tcode, int tlabel,
>  }
>  
>  static int allocate_tlabel(struct fw_card *card)
> -__must_hold(&card->transactions_lock)
> +__must_hold(&card->transactions.lock)
>  {
>  	int tlabel;

Applied to for-linus branch.


Regards

Takashi Sakamoto