linux-kernel - Re: [PATCH net-next] rtnetlink: honor RTEXT_FILTER_SKIP_STATS in IFLA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251023173312.7e0ad8ff@kernel.org>
Date: Thu, 23 Oct 2025 17:33:12 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc: Adrian Moreno <amorenoz@...hat.com>, netdev@...r.kernel.org,
 toke@...hat.com, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Kuniyuki Iwashima <kuniyu@...gle.com>, Stanislav
 Fomichev <sdf@...ichev.me>, Xiao Liang <shaw.leon@...il.com>, Cong Wang
 <cong.wang@...edance.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] rtnetlink: honor RTEXT_FILTER_SKIP_STATS in
 IFLA_STATS

On Thu, 23 Oct 2025 17:39:09 +0200 Nicolas Dichtel wrote:
> > +	if (~ext_filter_mask & RTEXT_FILTER_SKIP_STATS &&  
> Maybe parentheses around this first condition?
> 
> The size could be adjusted accordingly in if_nlmsg_size().

Slight preference here for no brackets unless compiler complains 
(or needed for correctness, of course).