linux-kernel - Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5fbb09f4-22e6-4073-a4e5-95165d3dabbb@rootcommit.com>
Date: Fri, 24 Oct 2025 05:36:47 +0000 (UTC)
From: Michael Opdenacker <michael.opdenacker@...tcommit.com>
To: Conor Dooley <conor@...nel.org>, Vivian Wang <wangruikang@...as.ac.cn>
Cc: michael.opdenacker@...tcommit.com, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Yixun Lan <dlan@...too.org>,
 Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>,
 Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
 Emil Renner Berthing <emil.renner.berthing@...il.com>,
 devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
 spacemit@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to
 OrangePi RV2

Hi Conor

Thanks for the review!

On 10/23/25 20:30, Conor Dooley wrote:
> On Thu, Oct 23, 2025 at 01:58:22PM +0800, Vivian Wang wrote:
>> Thank you so much for the patch and testing results. Only some nitpicks
>> follow.
>>
>> On 10/23/25 04:18, michael.opdenacker@...tcommit.com wrote:
>>> From: Michael Opdenacker <michael.opdenacker@...tcommit.com>
>>>
>>> The OrangePi RV2 board ships two RGMII ethernet ports.
>>> Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
>>> for reset pin control.
>>>
>>> Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
>>>
>>> Signed-off-by: Michael Opdenacker <michael.opdenacker@...tcommit.com>
>>> CC: Emil Renner Berthing <emil.renner.berthing@...il.com>
>>> CC: Yixun Lan <dlan@...too.org>
>>> CC: Vivian Wang <wangruikang@...as.ac.cn>
>> Firstly, it is usually spelt "Cc:", with one upper-case C and one
>> lower-case c.
> I don't think this matters at all, the git tooling at least doesn't
> care.
>
>> Secondly, "Cc:" should not be necessary in the patch/commit message.
>>  From Documentation/process/submitting-patches.rst:
>>
>>      If a person has had the opportunity to comment on a patch, but has not
>>      provided such comments, you may optionally add a ``Cc:`` tag to the patch.
>>      This tag documents that potentially interested parties have been included in
>>      the discussion.
>>
>> If you look through the git logs of Linux, Cc tags are really not a
>> regular occurrence except those marking patches as suitable for
>> backporting to stable.
> If people want to handle CC lists by putting it in the patches (it's
> what I do when I have no cover letter) just put them after the --- line
> and git send-email will still pick the CCs up but they won't end up in
> the history.

Oh yes, that was my mistake. The CCs were never intended to make it to 
the final commits.
Thanks!
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/