linux-kernel - Re: [PATCH next] gpio: qixis-fpga: Fix a NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DDQCS29MOR0K.2TOU2N8QR86Z0@kernel.org>
Date: Fri, 24 Oct 2025 08:53:40 +0200
From: "Michael Walle" <mwalle@...nel.org>
To: "Dan Carpenter" <dan.carpenter@...aro.org>, "Ioana Ciornei"
 <ioana.ciornei@....com>
Cc: "Linus Walleij" <linus.walleij@...aro.org>, "Bartosz Golaszewski"
 <brgl@...ev.pl>, "Frank Li" <Frank.Li@....com>,
 <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH next] gpio: qixis-fpga: Fix a NULL vs IS_ERR() bug in
 probe()

On Fri Oct 24, 2025 at 8:19 AM CEST, Dan Carpenter wrote:
> The devm_platform_ioremap_resource() function doesn't return NULL, it
> returns error pointers.  Fix the checking to match.
>
> Fixes: e88500247dc3 ("gpio: add QIXIS FPGA GPIO controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Michael Walle <mwalle@...nel.org>

-michael