linux-kernel - Re: [PATCH v2 net] sfc: fix potential memory leak in efx_mae_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4ef697b-74f4-4a47-ac0b-30608b204a4c@intel.com>
Date: Thu, 23 Oct 2025 17:48:12 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Abdun Nihaal <nihaal@....iitm.ac.in>, <ecree.xilinx@...il.com>
CC: <andrew+netdev@...n.ch>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <habetsm.xilinx@...il.com>,
	<alejandro.lucero-palau@....com>, <netdev@...r.kernel.org>,
	<linux-net-drivers@....com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 net] sfc: fix potential memory leak in
 efx_mae_process_mport()



On 10/23/2025 7:18 AM, Abdun Nihaal wrote:
> In efx_mae_enumerate_mports(), memory allocated for mae_mport_desc is
> passed as a argument to efx_mae_process_mport(), but when the error path
> in efx_mae_process_mport() gets executed, the memory allocated for desc
> gets leaked.
> 
> Fix that by freeing the memory allocation before returning error.
> 

Why not make the caller responsible for freeing desc on failure?


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)