linux-kernel - Re: [PATCH v4 2/2] regulator: max77675: Add MAX77675 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251024-aquatic-real-butterfly-f5d445@kuoka>
Date: Fri, 24 Oct 2025 09:11:34 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Joan-Na-adi <joan.na.devcode@...il.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	Joan Na <joan.na@...log.com>
Subject: Re: [PATCH v4 2/2] regulator: max77675: Add MAX77675 regulator driver

On Tue, Oct 21, 2025 at 02:08:30PM +0900, Joan-Na-adi wrote:
 +
> +		config.of_node = of_get_child_by_name(regulators_np, desc->name);
> +		if (!config.of_node) {
> +			dev_warn(maxreg->dev, "No DT node for regulator %s\n", desc->name);
> +			continue;
> +		}
> +
> +		rdev = devm_regulator_register(&client->dev, desc, &config);

You need to respond to the comments, not ignore them. I asked to drop
the reference here.

Best regards,
Krzysztof