linux-kernel - Re: [PATCH 4/4] iio: light: apds9960: convert to use maple tree register cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPs9HdeTZKoqFqdk@smile.fi.intel.com>
Date: Fri, 24 Oct 2025 11:47:25 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Chu Guangqing <chuguangqing@...pur.com>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com, jic23@...nel.org,
	dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org,
	subhajit.ghosh@...aklogic.com, javier.carrasco.cruz@...il.com,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] iio: light: apds9960: convert to use maple tree
 register cache

On Fri, Oct 24, 2025 at 03:38:23PM +0800, Chu Guangqing wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.

...

>  	.reg_defaults = apds9960_reg_defaults,
>  	.num_reg_defaults = ARRAY_SIZE(apds9960_reg_defaults),

^^^^ Be careful with such cases, the cache implementations may behave
differently. Have you tested this on the actual HW?

>  	.max_register = APDS9960_REG_GFIFO_DIR(RIGHT),
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>  };

-- 
With Best Regards,
Andy Shevchenko