| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aPtotO_FnA1i1AhX@fedora>
Date: Fri, 24 Oct 2025 13:53:24 +0200
From: José Expósito <jose.exposito89@...il.com>
To: Louis Chauvet <louis.chauvet@...tlin.com>
Cc: Haneen Mohammed <hamohammed.sa@...il.com>,
Simona Vetter <simona@...ll.ch>,
Melissa Wen <melissa.srw@...il.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Jonathan Corbet <corbet@....net>,
victoria@...tem76.com, sebastian.wick@...hat.com,
thomas.petazzoni@...tlin.com, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH 03/22] drm/vkms: Introduce config for plane rotation
On Sat, Oct 18, 2025 at 04:01:03AM +0200, Louis Chauvet wrote:
> VKMS driver supports all the rotation on planes, but for testing it can be
> useful to only advertise few of them. This new configuration interface
> will allow configuring the rotation per planes.
>
> Signed-off-by: Louis Chauvet <louis.chauvet@...tlin.com>
> ---
> drivers/gpu/drm/vkms/vkms_config.c | 26 ++++++++++++++++++
> drivers/gpu/drm/vkms/vkms_config.h | 54 ++++++++++++++++++++++++++++++++++++++
> drivers/gpu/drm/vkms/vkms_plane.c | 6 +++--
> 3 files changed, 84 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_config.c b/drivers/gpu/drm/vkms/vkms_config.c
> index ed172f800685..b8cabe6f6cf8 100644
> --- a/drivers/gpu/drm/vkms/vkms_config.c
> +++ b/drivers/gpu/drm/vkms/vkms_config.c
> @@ -144,6 +144,22 @@ static bool valid_plane_number(const struct vkms_config *config)
> return true;
> }
>
> +static bool valid_plane_properties(const struct vkms_config *config)
> +{
> + struct drm_device *dev = config->dev ? &config->dev->drm : NULL;
> + struct vkms_config_plane *plane_cfg;
> +
> + vkms_config_for_each_plane(config, plane_cfg) {
> + if ((vkms_config_plane_get_default_rotation(plane_cfg) &
> + vkms_config_plane_get_supported_rotations(plane_cfg)) !=
> + vkms_config_plane_get_default_rotation(plane_cfg)) {
> + drm_info(dev, "Configured default rotation is not supported by the plane\n");
> + return false;
> + }
> + }
> + return true;
> +}
> +
> static bool valid_planes_for_crtc(const struct vkms_config *config,
> struct vkms_config_crtc *crtc_cfg)
> {
> @@ -302,6 +318,9 @@ bool vkms_config_is_valid(const struct vkms_config *config)
> {
> struct vkms_config_crtc *crtc_cfg;
>
> + if (!valid_plane_properties(config))
> + return false;
> +
I think that it makes sense to check this after we are sure that the number
of display pipeline items are correct and they are linked correctly, i.e., at
the end of the function.
Also, for testing purposes, it'd be usefull to have something like:
vkms_config_for_each_plane(config, plane_cfg) {
if (!valid_plane_name(plane_cfg)
return false;
if (!valid_plane_rotation(plane_cfg)
return false;
// ...
}
This would allow us to have smaller functions and also write unit tests
for them easily.
What do you think?
> if (!valid_plane_number(config))
> return false;
>
> @@ -352,6 +371,10 @@ static int vkms_config_show(struct seq_file *m, void *data)
> vkms_config_plane_get_type(plane_cfg));
> seq_printf(m, "\tname=%s\n",
> vkms_config_plane_get_name(plane_cfg));
> + seq_printf(m, "\tsupported rotations: 0x%x\n",
> + vkms_config_plane_get_supported_rotations(plane_cfg));
> + seq_printf(m, "\tdefault rotation: 0x%x\n",
> + vkms_config_plane_get_default_rotation(plane_cfg));
> }
>
> vkms_config_for_each_crtc(vkmsdev->config, crtc_cfg) {
> @@ -393,6 +416,9 @@ struct vkms_config_plane *vkms_config_create_plane(struct vkms_config *config)
> plane_cfg->config = config;
> vkms_config_plane_set_type(plane_cfg, DRM_PLANE_TYPE_OVERLAY);
> vkms_config_plane_set_name(plane_cfg, NULL);
> + vkms_config_plane_set_supported_rotations(plane_cfg, DRM_MODE_ROTATE_MASK);
> + vkms_config_plane_set_default_rotation(plane_cfg, DRM_MODE_ROTATE_0);
At the moment, drm_info returns this rotation for the default VKMS device:
"rotation": bitmask {rotate-0, rotate-90, rotate-180, rotate-270, reflect-x, reflect-y} = (rotate-0)
With this patch, this is returned:
"rotation": bitmask {rotate-0, rotate-90, rotate-180, rotate-270} = (rotate-0)
You need to add DRM_MODE_REFLECT_MASK to avoid changing the default device.
Ideally, we should add an IGT test to make sure we don't change any value
accidentally.
> +
> xa_init_flags(&plane_cfg->possible_crtcs, XA_FLAGS_ALLOC);
>
> list_add_tail(&plane_cfg->link, &config->planes);
> diff --git a/drivers/gpu/drm/vkms/vkms_config.h b/drivers/gpu/drm/vkms/vkms_config.h
> index b69c35097ba0..3c3cbefcc67f 100644
> --- a/drivers/gpu/drm/vkms/vkms_config.h
> +++ b/drivers/gpu/drm/vkms/vkms_config.h
> @@ -39,6 +39,8 @@ struct vkms_config {
> * @type: Type of the plane. The creator of configuration needs to ensures that
> * at least one primary plane is present.
> * @possible_crtcs: Array of CRTCs that can be used with this plane
> + * @default_rotation: Default rotation that should be used by this plane
> + * @supported_rotation: Rotation that this plane will support
Missing final s: @supported_rotations
> * @plane: Internal usage. This pointer should never be considered as valid.
> * It can be used to store a temporary reference to a VKMS plane during
> * device creation. This pointer is not managed by the configuration and
> @@ -50,6 +52,8 @@ struct vkms_config_plane {
>
> const char *name;
> enum drm_plane_type type;
> + unsigned int default_rotation;
> + unsigned int supported_rotations;
> struct xarray possible_crtcs;
>
> /* Internal usage */
> @@ -290,6 +294,56 @@ vkms_config_plane_set_type(struct vkms_config_plane *plane_cfg,
> plane_cfg->type = type;
> }
>
> +/**
> + * vkms_config_plane_get_default_rotation() - Get the default rotation for a plane
> + * @plane_cfg: Plane to get the default rotation from
> + *
> + * Returns:
> + * The default rotation for the plane.
> + */
> +static inline unsigned int
> +vkms_config_plane_get_default_rotation(struct vkms_config_plane *plane_cfg)
> +{
> + return plane_cfg->default_rotation;
> +}
> +
> +/**
> + * vkms_config_plane_set_default_rotation() - Set the default rotation for a plane
> + * @plane_cfg: Plane to set the default rotation to
> + * @default_rotation: New default rotation for the plane
> + */
> +static inline void
> +vkms_config_plane_set_default_rotation(struct vkms_config_plane *plane_cfg,
> + unsigned int default_rotation)
> +{
> + plane_cfg->default_rotation = default_rotation;
> +}
> +
> +/**
> + * vkms_config_plane_get_supported_rotations() - Get the supported rotations for a plane
> + * @plane_cfg: Plane to get the supported rotations from
> + *
> + * Returns:
> + * The supported rotations for the plane.
> + */
> +static inline unsigned int
> +vkms_config_plane_get_supported_rotations(struct vkms_config_plane *plane_cfg)
> +{
> + return plane_cfg->supported_rotations;
> +}
> +
> +/**
> + * vkms_config_plane_set_supported_rotations() - Set the supported rotations for a plane
> + * @plane_cfg: Plane to set the supported rotations to
> + * @supported_rotations: New supported rotations for the plane
> + */
> +static inline void
> +vkms_config_plane_set_supported_rotations(struct vkms_config_plane *plane_cfg,
> + unsigned int supported_rotations)
> +{
> + plane_cfg->supported_rotations = supported_rotations;
> +}
> +
> /**
> * vkms_config_plane_set_name() - Set the plane name
> * @plane_cfg: Plane to set the name to
> diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c
> index 263376686794..6e6bfe1b7400 100644
> --- a/drivers/gpu/drm/vkms/vkms_plane.c
> +++ b/drivers/gpu/drm/vkms/vkms_plane.c
> @@ -1,5 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0+
>
> +#include "vkms_config.h"
This include is already present.
> #include <linux/iosys-map.h>
>
> #include <drm/drm_atomic.h>
> @@ -233,8 +234,9 @@ struct vkms_plane *vkms_plane_init(struct vkms_device *vkmsdev,
>
> drm_plane_helper_add(&plane->base, &vkms_plane_helper_funcs);
>
> - drm_plane_create_rotation_property(&plane->base, DRM_MODE_ROTATE_0,
> - DRM_MODE_ROTATE_MASK | DRM_MODE_REFLECT_MASK);
> + drm_plane_create_rotation_property(&plane->base,
> + vkms_config_plane_get_default_rotation(config),
> + vkms_config_plane_get_supported_rotations(config));
>
> drm_plane_create_color_properties(&plane->base,
> BIT(DRM_COLOR_YCBCR_BT601) |
>
> --
> 2.51.0
>
Powered by blists - more mailing lists