linux-kernel - Re: [PATCH v1 1/1] HID: intel-ish-hid: Fix a build error in devm_ishtp_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3qq2o1r0-q920-3986-q9p5-44p9oorq74qp@xreary.bet>
Date: Fri, 24 Oct 2025 14:27:03 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
cc: Zhang Lixu <lixu.zhang@...el.com>, 
    Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, 
    linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, 
    llvm@...ts.linux.dev, Benjamin Tissoires <bentiss@...nel.org>, 
    Nathan Chancellor <nathan@...nel.org>, 
    Nick Desaulniers <nick.desaulniers+lkml@...il.com>, 
    Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH v1 1/1] HID: intel-ish-hid: Fix a build error in
 devm_ishtp_alloc_workqueue()

On Fri, 24 Oct 2025, Andy Shevchenko wrote:

> clang 19 is not happy about the cast and in conjunction with CONFIG_WERROR=y
> (which is default) leads to a build error:
> 
> drivers/hid/intel-ish-hid/ipc/ipc.c:935:36: error: cast from 'void (*)(struct workqueue_struct *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
>   935 |         if (devm_add_action_or_reset(dev, (void (*)(void *))destroy_workqueue,
>       |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fix this by providing an intermediate callback that has a correct type.
> 
> Fixes: 0d30dae38fe0 ("HID: intel-ish-hid: Use dedicated unbound workqueues to prevent resume blocking")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Thanks Andy. Nathan beat you on this one:

	https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-6.19/intel-ish-v2&id=3644f4411713f52bf231574aa8759e3d8e20b341

-- 
Jiri Kosina
SUSE Labs