linux-kernel - Re: [resend, PATCH v2 1/1] kexec: Remove unused code in kimage_load_cma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPt5CYz5Cc-7St6L@black.igk.intel.com>
Date: Fri, 24 Oct 2025 15:03:05 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Justinien Bouron <jbouron@...zon.com>
Cc: kexec@...ts.infradead.org, linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev, Andrew Morton <akpm@...ux-foundation.org>,
	Baoquan He <bhe@...hat.com>, Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>
Subject: Re: [resend, PATCH v2 1/1] kexec: Remove unused code in
 kimage_load_cma_segment()

On Mon, Oct 13, 2025 at 11:48:24PM +0300, Andy Shevchenko wrote:
> On Tue, Sep 23, 2025 at 10:50:55AM -0700, Justinien Bouron wrote:
> > On Tue, Sep 16, 2025 at 02:51:09PM +0200, Andy Shevchenko wrote:
> > > clang is not happy about set but unused variable:
> > > 
> > > kernel/kexec_core.c:745:16: error: variable 'maddr' set but not used [-Werror,-Wunused-but-set-variable]
> > >   745 |         unsigned long maddr;
> > >       |                       ^
> > > 1 error generated.
> > > 
> > > Fix the compilation breakage (`make W=1` build) by removing unused variable.
> > > 
> > > As Nathan noted, GCC 16 produces the similar warning;
> > > 
> > > Fixes: f4fecb50d6e1 ("kexec_core: remove superfluous page offset handling in segment loading")
> > FYI the commit this patch is fixing (i.e. f4fecb50d6e1) is going to need a
> > second revision as well (I haven't submitted it yet, still working on it), this
> > means that your "Fixes:" tag will need to be changed again, requiring a 3rd
> > revision.
> > 
> > I am not sure what is the proper way forward here. Should I:
> >     - Send my v2, without fixing the unused variable and then you send your v3
> >       with the updated "Fixes:" tag pointing to my v2.
> >     - OR fixing the unused variable in my v2 (i.e. "absorb" this patch in my
> >       v2).
> 
> Second is the best (integrate this fix into yours v2).
> 
> > In the latter case, I am not sure how I am supposed to credit the work in this
> > case? Do I need to add another "Signed-off-by: Andy Shevchenko" besides mine?
> 
> Just in the comment block (after the cutter '---' line and before the diff) in
> a free words. No need for any special tags for this in such a case.
> 
> > I'm still learning the ropes on how to contribute through the mailing list so I
> > would be grateful if you could share your input on what's the proper way forward
> > here.

Any news, folks, please? The bug is still in Linux Next and prevents me from
building my stuff cleanly.

-- 
With Best Regards,
Andy Shevchenko