linux-kernel - Re: [PATCH] regmap: irq: Correct documentation of wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPt6_lzhFYy5w0l0@finisterre.sirena.org.uk>
Date: Fri, 24 Oct 2025 14:11:26 +0100
From: Mark Brown <broonie@...nel.org>
To: Shawn Guo <shawnguo2@...h.net>
Cc: Philipp Zabel <p.zabel@...gutronix.de>, linux-kernel@...r.kernel.org,
	Shawn Guo <shawnguo@...nel.org>, stable@...r.kernel.org
Subject: Re: [PATCH] regmap: irq: Correct documentation of wake_invert flag

On Fri, Oct 24, 2025 at 04:23:44PM +0800, Shawn Guo wrote:

> Per commit 9442490a0286 ("regmap: irq: Support wake IRQ mask inversion")
> the wake_invert flag is to support enable register, so cleared bits are
> wake disabled.

> - * @wake_invert: Inverted wake register: cleared bits are wake enabled.
> + * @wake_invert: Inverted wake register: cleared bits are wake disabled.

That sounds like what I'd expect for a normal polarity wake register?
I'd expect to set the bit to enable, so inverting that means that
instead we clear the bit which is what the original text says.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)