linux-kernel - Re: [PATCH] hwmon: (gpd-fan) Fix compilation error in non-ACPI builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a1e1503-0529-41f6-806d-0ecf0f8e77fe@roeck-us.net>
Date: Sat, 25 Oct 2025 01:19:54 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Gopi Krishna Menon <krishnagopi487@...il.com>
Cc: cryolitia@...ontech.com, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
	david.hunter.linux@...il.com, khalid@...nel.org,
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] hwmon: (gpd-fan) Fix compilation error in non-ACPI builds

On Sat, Oct 25, 2025 at 01:50:40AM +0530, Gopi Krishna Menon wrote:
> Building gpd-fan driver without CONFIG_ACPI results in the following
> build errors:
> 
> drivers/hwmon/gpd-fan.c: In function ‘gpd_ecram_read’:
> drivers/hwmon/gpd-fan.c:228:9: error: implicit declaration of function ‘outb’ [-Werror=implicit-function-declaration]
>   228 |         outb(0x2E, addr_port);
>       |         ^~~~
> drivers/hwmon/gpd-fan.c:241:16: error: implicit declaration of function ‘inb’ [-Werror=implicit-function-declaration]
>   241 |         *val = inb(data_port);
> 
> The definitions for inb() and outb() come from <linux/io.h>
> (specifically through <asm/io.h>), which is implicitly included via
> <acpi_io.h>. When CONFIG_ACPI is not set, <acpi_io.h> is not included
> resulting in <linux/io.h> to be omitted as well.
> 
> Since the driver does not depend on ACPI, remove <linux/acpi.h> and add
> <linux/io.h> directly to fix the compilation errors.
> 
> Signed-off-by: Gopi Krishna Menon <krishnagopi487@...il.com>

Applied.

Thanks,
Guenter