linux-kernel - Re: [PATCH v3 06/14] iommu/mediatek: fix use-after-free on probe deferral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7eb3fd3a200396ab5cd5b9227b31eeddab41db80.camel@mediatek.com>
Date: Sat, 25 Oct 2025 09:18:30 +0000
From: Yong Wu (吴勇) <Yong.Wu@...iatek.com>
To: "joro@...tes.org" <joro@...tes.org>, "will@...nel.org" <will@...nel.org>,
	"johan@...nel.org" <johan@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"j@...nau.net" <j@...nau.net>, "vdumpa@...dia.com" <vdumpa@...dia.com>,
	"robin.murphy@....com" <robin.murphy@....com>, "m.szyprowski@...sung.com"
	<m.szyprowski@...sung.com>, "wens@...e.org" <wens@...e.org>,
	"thierry.reding@...il.com" <thierry.reding@...il.com>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>, "iommu@...ts.linux.dev"
	<iommu@...ts.linux.dev>, "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	"robin.clark@....qualcomm.com" <robin.clark@....qualcomm.com>,
	"sven@...nel.org" <sven@...nel.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v3 06/14] iommu/mediatek: fix use-after-free on probe
 deferral

On Mon, 2025-10-20 at 06:53 +0200, Johan Hovold wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> The driver is dropping the references taken to the larb devices
> during
> probe after successful lookup as well as on errors. This can
> potentially lead to a use-after-free in case a larb device has not
> yet
> been bound to its driver so that the iommu driver probe defers.
> 
> Fix this by keeping the references as expected while the iommu driver
> is
> bound.
> 
> Fixes: 26593928564c ("iommu/mediatek: Add error path for loop of
> mm_dts_parse")
> Cc: stable@...r.kernel.org
> Cc: Yong Wu <yong.wu@...iatek.com>
> Acked-by: Robin Murphy <robin.murphy@....com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---

Reviewed-by: Yong Wu <yong.wu@...iatek.com>