linux-kernel - Re: [PATCH] arm64: dts: rockchip: Add devicetree for the X3568 v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2940731.88bMQJbFj6@phil>
Date: Sat, 25 Oct 2025 23:03:11 +0200
From: Heiko Stuebner <heiko@...ech.de>
To: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Dragan Simic <dsimic@...jaro.org>,
 Jonas Karlman <jonas@...boo.se>, Coia Prant <coiaprant@...il.com>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org, Coia Prant <coiaprant@...il.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Add devicetree for the X3568 v4

Hi,

general comments, I haven't disected the devicetrees yet.


Am Samstag, 25. Oktober 2025, 22:37:11 Mitteleuropäische Sommerzeit schrieb Coia Prant:

Please also provide some description what type of board this is,
not just a list of specs

> Specification:
> - SoC: RockChip RK3568 ARM64 (4 cores)
> - eMMC: 16-128 GB
> - RAM: 2-8 GB
> - Power: DC 12V 2A
> - Ethernet: 2x YT8521SC RGMII (10/100/1000 Mbps)
> - Wireless radio: 802.11b/g/n/ac/ax dual-band
> - LED:
>   Power: AlwaysOn
>   User: GPIO
> - Button:
>   VOL+: SARADC/0 <35k µV>
>   VOL-: SARADC/0 <450k µV>
>   Power/Reset: PMIC RK809
> - CAN
>   CAN/1: 4-pin (PH 2.0)
> - PWM
>   PWM/4: Backlight DSI/0 DSI/1
>   PWM/7: IR Receiver [may not install]
> - UART:
>   UART/2: Debug TTL - 1500000 8N1 (1.25mm)
>   UART/3: TTL (PH 2.0)
>   UART/4: TTL (PH 2.0)
>   UART/8: AP6275S Bluetooth
>   UART/9: TTL (PH 2.0)
> - I2C:
>   I2C/0: PMIC RK809
>   I2C/1: Touchscreen DSI/0 DSI/1
>   I2C/4: Camera
>   I2C/5: RTC@51 PCF8563
> - I2S:
>   I2S/0: miniHDMI Sound
>   I2S/1: RK809 Audio Codec
>   I2S/3: AP6275S Bluetooth Sound
> - SDMMC:
>   SDMMC/0: microSD (TF) slot
>   SDMMC/2: AP6275S SDIO WiFi card
> - Camera: 1x CSI
> - Video: miniHDMI / DSI0 (MIPI/LVDS) / DSI1 (MIPI/EDP)
> - Audio: miniHDMI / MIC on-board / Speaker / SPDIF / 3.5mm Headphones / AP6275S Bluetooth
> - USB:
>   USB 2.0 HOST x2
>   USB 2.0 HOST x3 (4-pin)
>   USB 2.0 OTG x1 (shared with USB 3.0 OTG/HOST) [slot may not install]
>   USB 3.0 HOST x1
>   USB 3.0 OTG/HOST x1
> - SATA: 1x SATA 3.0 with Power/4-pin [slot may not install]
> - PCIe: 1x PCIe 3.0 x2 (x4 connecter) [clock/slot may not install]
> 
> Link:
> - https://appletsapi.52solution.com/media/X3568V4%E5%BC%80%E5%8F%91%E6%9D%BF%E7%A1%AC%E4%BB%B6%E6%89%8B%E5%86%8C.pdf
> - https://blog.gov.cooking/archives/research-ninetripod-x3568-v4-and-flash.html

2nd link ends in a 404 error, page not found


> Signed-off-by: Coia Prant <coiaprant@...il.com>
> Tested-by: Coia Prant <coiaprant@...il.com>


When you submit a patch, we expect you to have tested it, so tere
is no need to have a separate tested-by line :-) .


> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |  11 +
>  .../rockchip/rk3568-x3568-camera-demo.dtso    |  82 ++
>  .../boot/dts/rockchip/rk3568-x3568-v4.dts     | 884 ++++++++++++++++++
>  .../dts/rockchip/rk3568-x3568-video-demo.dtso | 141 +++

please name your boards including the ninetree name, because x3568 is way
too generic, so
rk3568-ninetree-x3568 .....

Additionally, from that PDF above, it seems this is a system-on-module?
X3568CV2 + baseboard? If so, please split this into a dtsi + dts.
See all the other system-on-modules for reference.

Additionally, you'll need to have a 2nd patch to add the board to
Documentation/devicetree/bindings/arm/rockchip.yaml

And also possily a 3rd patch to add ninetree to
Documentation/devicetree/bindings/vendor-prefixes.yaml


Heiko