linux-kernel - Re: [PATCH v2] pinctrl: starfive: use dynamic GPIO base allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0881d989-c1f7-484f-a5e6-aee47ee5c5d6@gmail.com>
Date: Sun, 26 Oct 2025 02:29:11 +0500
From: Ali Tariq <alitariq45892@...il.com>
To: Emil Renner Berthing <emil.renner.berthing@...onical.com>
Cc: hal.feng@...rfivetech.com, linus.walleij@...aro.org,
 linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
 Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v2] pinctrl: starfive: use dynamic GPIO base allocation

Hi Emil,

Thanks for the review and feedback.

Quoting Emil Renner Berthing:
 > 1) The justification for why this is no longer needed should be in 
the commit
 > message, and not just in a random thread that will soon be forgotten.

My apologies for the confusion. I did add the removal of unused 
variables as a bullet point in the v2 changelog (which is in the email 
body), but I failed to include the necessary justification for this 
removal in the main commit message itself.

You are correct, the justification for removing `gc_base` and associated 
macros (because we now use `sfp->gc.base = -1` for dynamic allocation) 
belongs in the permanent commit message.

I will update the v2 commit message to clearly state the removal of 
macros and unused definitions (before "Signed-off-by") in the v3 submission.

Quoting Emil Renner Berthing:
 > 2) Please don't send new revisions as replies. Start a new mail thread.

Understood. I will send the next revision as a new thread.

Quoting Emil Renner Berthing:
 > The code changes look good though, so once that is fixed you can add
 >
 > Reviewed-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>

Understood. I will include your Reviewed-by tag in the v3 patch.

Thanks again for the review!

-Ali