linux-kernel - Re: [PATCH] selftests/seccomp: fix pointer type mismatch in UPROBE test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da05d1d1-c241-49af-bed8-7db5e9968396@gmail.com>
Date: Sun, 26 Oct 2025 14:28:46 +0530
From: Nirbhay Sharma <nirbhay.lkd@...il.com>
To: Jiri Olsa <olsajiri@...il.com>
Cc: Kees Cook <kees@...nel.org>, Shuah Khan <shuah@...nel.org>,
 Andy Lutomirski <luto@...capital.net>, Will Drewry <wad@...omium.org>,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 bpf@...r.kernel.org, khalid@...nel.org, david.hunter.linux@...il.com,
 linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] selftests/seccomp: fix pointer type mismatch in UPROBE
 test



Hi Jiri,

Thank you for the review and for catching that inaccuracy!

On 10/26/25 2:48 AM, Jiri Olsa wrote:
> just probed_uprobe right?

Yes, you're absolutely correct. Only probed_uprobe has the
__attribute__((nocf_check)) attribute. I apologize for the confusion
in my original commit message. I'll fix this in v2.

> curious what compiler do you see that with?

I am seeing this error with Clang 19.1.2 on Fedora, which enables
-fcf-protection=full by default. As Sam confirmed, the error occurs
specifically when CFI protection is enabled via -fcf-protection. GCC
without this flag treats it as a warning or ignores the nocf_check
attribute entirely.

I'll send v2 with the corrected commit message.

Thanks again for the review!

Best regards,
Nirbhay