linux-kernel - Re: [PATCH net] dt-bindings: net: sparx5: correct LAN969x register space windows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f94c2766-6c68-468c-83c7-4f4c8000f026@kernel.org>
Date: Sun, 26 Oct 2025 11:11:23 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Robert Marko <robert.marko@...tura.hr>, andrew+netdev@...n.ch,
 davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, Steen.Hegelund@...rochip.com,
 daniel.machon@...rochip.com, UNGLinuxDriver@...rochip.com,
 lars.povlsen@...rochip.com, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Cc: luka.perkov@...tura.hr, benjamin.ryzman@...onical.com
Subject: Re: [PATCH net] dt-bindings: net: sparx5: correct LAN969x register
 space windows

On 25/09/2025 15:19, Robert Marko wrote:
> LAN969x needs only 2 register space windows as GCB is already covered by
> the "devices" register space window, so expect only 2 "reg" and "reg-names"
> properties.
> 
> Fixes: 41c6439fdc2b ("dt-bindings: net: add compatible strings for lan969x targets")
> Signed-off-by: Robert Marko <robert.marko@...tura.hr>
> ---
>  .../bindings/net/microchip,sparx5-switch.yaml | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> index 082982c59a55..5caa3779660d 100644
> --- a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
> @@ -55,12 +55,14 @@ properties:
>            - const: microchip,lan9691-switch
>  
>    reg:
> +    minItems: 2
>      items:
>        - description: cpu target
>        - description: devices target
>        - description: general control block target
>  
>    reg-names:
> +    minItems: 2
>      items:
>        - const: cpu
>        - const: devices
> @@ -168,6 +170,26 @@ required:
>    - interrupt-names
>    - ethernet-ports
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - microchip,lan9691-switch
> +    then:
> +      properties:
> +        reg:
> +          minItems: 2

This is wrong. You wanted maxItems.

Best regards,
Krzysztof