linux-kernel - Re: [PATCH v7 2/4] Add SPAcc ahash support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALxtO0=4iJho3fqVuQbV+CQyhYqc4zbmNNGeSy03go-iy758aw@mail.gmail.com>
Date: Sun, 26 Oct 2025 17:09:00 +0530
From: Pavitrakumar Managutte <pavitrakumarm@...avyalabs.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-crypto@...r.kernel.org, devicetree@...r.kernel.org, 
	Bhoomika Kadabi <bhoomikak@...avyalabs.com>, 
	Manjunath Hadli <manjunath.hadli@...avyalabs.com>, Ruud Derwig <Ruud.Derwig@...opsys.com>, 
	Herbert Xu <herbert@...dor.apana.org.au>, Rob Herring <robh@...nel.org>, 
	LKML <linux-kernel@...r.kernel.org>, Aditya Kulkarni <adityak@...avyalabs.com>, 
	Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, T Pratham <t-pratham@...com>
Subject: Re: [PATCH v7 2/4] Add SPAcc ahash support

Hi Markus,
  My comments below

Warm regards,
PK

On Fri, Oct 17, 2025 at 4:36 PM Markus Elfring <Markus.Elfring@....de> wrote:
>
> >> …
> >>> +do_shash_err:
> >>> +     crypto_free_shash(hash);
> >>> +     kfree(sdesc);
> >>> +
> >>> +     return rc;
> >>> +}
> >> …
> >>
> >> * You may use an additional label for better exception handling.
> > PK: Ack, I will go with an additional label.
>
> Can scope-based resource management become applicable for more use cases?
PK: Yes, wherever applicable we will make the changes. I do see a few
use cases in the SPAcc driver code.

>
> Regards,
> Markus