linux-kernel - Re: [PATCH v2 1/2] nvme-pci: migrate to dma_map_phys instead of map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251026123804.GD12554@unreal>
Date: Sun, 26 Oct 2025 14:38:04 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: Jens Axboe <axboe@...nel.dk>, Keith Busch <kbusch@...nel.org>,
	Sagi Grimberg <sagi@...mberg.me>, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] nvme-pci: migrate to dma_map_phys instead of
 map_page

On Wed, Oct 22, 2025 at 08:14:18AM +0200, Christoph Hellwig wrote:
> This actually has block and nvme bits, so the subject line should
> say that.
> 
> > +	unsigned int attrs = 0;
> 
> attrs is always zero here, no need to start passing it for the
> map_phys conversion alone.
> 
> > +	unsigned int attrs = 0;
> 
> Same here.

It gave me more clean second patch where I only added new attribute, but
if it doesn't look right to you, let's change.

> 
> > +	unsigned int			attrs;
> 
> And this is also entirely unused as far as I can tell.

Right, it is used in second patch, will fix.

Thanks