| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202510260921.IcI6vsTN-lkp@intel.com>
Date: Sun, 26 Oct 2025 09:37:53 +0800
From: kernel test robot <lkp@...el.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
alexandre.belloni@...tlin.com
Cc: oe-kbuild-all@...ts.linux.dev, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, matthias.bgg@...il.com,
angelogioacchino.delregno@...labora.com, linux-rtc@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH v1 2/2] rtc: Add support for MT6685 Clock IC's RTC over
SPMI
Hi AngeloGioacchino,
kernel test robot noticed the following build errors:
[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on robh/for-next linus/master v6.18-rc2 next-20251024]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/AngeloGioacchino-Del-Regno/dt-bindings-rtc-Add-MediaTek-MT6685-PM-Clock-IC-Real-Time-Clock/20251024-164423
base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
patch link: https://lore.kernel.org/r/20251024083318.25890-3-angelogioacchino.delregno%40collabora.com
patch subject: [PATCH v1 2/2] rtc: Add support for MT6685 Clock IC's RTC over SPMI
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20251026/202510260921.IcI6vsTN-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251026/202510260921.IcI6vsTN-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510260921.IcI6vsTN-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/rtc/rtc-mt6685.c: In function 'rtc_mt6685_probe':
>> drivers/rtc/rtc-mt6685.c:380:20: error: implicit declaration of function 'devm_spmi_subdevice_alloc_and_add' [-Wimplicit-function-declaration]
380 | sub_sdev = devm_spmi_subdevice_alloc_and_add(dev, sparent);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/rtc/rtc-mt6685.c:380:18: error: assignment to 'struct spmi_subdevice *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
380 | sub_sdev = devm_spmi_subdevice_alloc_and_add(dev, sparent);
| ^
In file included from drivers/rtc/rtc-mt6685.c:20:
>> drivers/rtc/rtc-mt6685.c:397:58: error: invalid use of undefined type 'struct spmi_subdevice'
397 | rtc->regmap = devm_regmap_init_spmi_ext(&sub_sdev->sdev, &mt6685_rtc_regmap_config);
| ^~
include/linux/regmap.h:782:52: note: in definition of macro '__regmap_lockdep_wrapper'
782 | #define __regmap_lockdep_wrapper(fn, name, ...) fn(__VA_ARGS__, NULL, NULL)
| ^~~~~~~~~~~
drivers/rtc/rtc-mt6685.c:397:23: note: in expansion of macro 'devm_regmap_init_spmi_ext'
397 | rtc->regmap = devm_regmap_init_spmi_ext(&sub_sdev->sdev, &mt6685_rtc_regmap_config);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +/devm_spmi_subdevice_alloc_and_add +380 drivers/rtc/rtc-mt6685.c
358
359 static int rtc_mt6685_probe(struct platform_device *pdev)
360 {
361 struct regmap_config mt6685_rtc_regmap_config = {
362 .reg_bits = 16,
363 .val_bits = 8,
364 .max_register = 0x60,
365 .fast_io = true,
366 .use_single_read = true,
367 .use_single_write = true,
368 };
369 struct device *dev = &pdev->dev;
370 struct spmi_subdevice *sub_sdev;
371 struct spmi_device *sparent;
372 struct mt6685_rtc *rtc;
373 int ret;
374
375 rtc = devm_kzalloc(dev, sizeof(struct mt6685_rtc), GFP_KERNEL);
376 if (!rtc)
377 return -ENOMEM;
378
379 sparent = to_spmi_device(dev->parent);
> 380 sub_sdev = devm_spmi_subdevice_alloc_and_add(dev, sparent);
381 if (IS_ERR(sub_sdev))
382 return PTR_ERR(sub_sdev);
383
384 ret = of_property_read_u32(pdev->dev.of_node, "reg",
385 &mt6685_rtc_regmap_config.reg_base);
386 if (ret)
387 return ret;
388
389 rtc->irq = platform_get_irq(pdev, 0);
390 if (rtc->irq < 0)
391 return rtc->irq;
392
393 rtc->mclk = devm_clk_get(dev, 0);
394 if (IS_ERR(rtc->mclk))
395 return PTR_ERR(rtc->mclk);
396
> 397 rtc->regmap = devm_regmap_init_spmi_ext(&sub_sdev->sdev, &mt6685_rtc_regmap_config);
398 if (IS_ERR(rtc->regmap))
399 return PTR_ERR(rtc->regmap);
400
401 rtc->rdev = devm_rtc_allocate_device(dev);
402 if (IS_ERR(rtc->rdev))
403 return PTR_ERR(rtc->rdev);
404
405 platform_set_drvdata(pdev, rtc);
406
407 /* Clock is required to auto-synchronize IRQ enable to RTC */
408 ret = clk_prepare_enable(rtc->mclk);
409 if (ret)
410 return ret;
411
412 ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,
413 rtc_mt6685_irq_handler_thread,
414 IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
415 "mt6685-rtc", rtc);
416 clk_disable_unprepare(rtc->mclk);
417 if (ret)
418 return dev_err_probe(&pdev->dev, ret, "Cannot request alarm IRQ");
419
420 device_init_wakeup(&pdev->dev, true);
421
422 rtc->rdev->ops = &rtc_mt6685_ops;
423 rtc->rdev->range_min = RTC_TIMESTAMP_BEGIN_1900;
424 rtc->rdev->range_max = mktime64(2027, 12, 31, 23, 59, 59);
425 rtc->rdev->start_secs = mktime64(1968, 1, 1, 0, 0, 0);
426 rtc->rdev->set_start_time = true;
427
428 return devm_rtc_register_device(rtc->rdev);
429 }
430
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists