| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <lyu4x54r7dmtj4hcggsgzupcz6vzmflubm5bq2zafxgnyhjako@a74xbq3d6tyd>
Date: Sun, 26 Oct 2025 17:35:15 +0100
From: Jorge Marques <gastmaier@...il.com>
To: Conor Dooley <conor@...nel.org>
Cc: Jorge Marques <jorge.marques@...log.com>,
Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>,
Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>,
Nuno Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Jonathan Corbet <corbet@....net>, linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH 1/7] dt-bindings: iio: adc: Add adi,ad4062
On Mon, Oct 13, 2025 at 08:50:31PM +0100, Conor Dooley wrote:
> On Mon, Oct 13, 2025 at 09:27:59AM +0200, Jorge Marques wrote:
> > Add dt-bindings for AD4062 family, devices AD4060/AD4062, low-power with
> > monitor capabilities SAR ADCs. Each variant of the family differs in
> > granuality. The device contains two outputs (gp0, gp1). The outputs can
> > be configured for range of options, such as threshold and data ready.
> > The device uses a 2-wire I3C interface.
> >
> > Signed-off-by: Jorge Marques <jorge.marques@...log.com>
> > ---
> > .../devicetree/bindings/iio/adc/adi,ad4062.yaml | 83 ++++++++++++++++++++++
> > MAINTAINERS | 6 ++
> > 2 files changed, 89 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4062.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4062.yaml
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..dcf86088fc4f32de7ad681561a09bad2755af04c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4062.yaml
> > @@ -0,0 +1,83 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright 2024 Analog Devices Inc.
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/adc/adi,ad4062.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices AD4062 ADC family device driver
> > +
> > +maintainers:
> > + - Jorge Marques <jorge.marques@...log.com>
> > +
> > +description: |
> > + Analog Devices AD4062 Single Channel Precision SAR ADC family
> > +
> > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4060.pdf
> > + https://www.analog.com/media/en/technical-documentation/data-sheets/ad4062.pdf
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - adi,ad4060
> > + - adi,ad4062
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + minItems: 1
> > + maxItems: 2
> > +
> > + interrupt-names:
> > + items:
> > + - const: gp0
> > + description: Signal coming from the GP0 pin.
> > + - const: gp1
> > + description: Signal coming from the GP1 pin.
Hi Conor,
>
> Please move the descriptions to the interrupts property, by creating an
> items list there. I think more information should probably be provided
> about them, than just "signal coming from", perhaps referencing the
> ability for what the signal actually represents being controllable at
> runtime.
I will add a short description of all mode that can be configured to
during runtime. Since both can be configured to any mode except gp0 as
dev_rdy, I will add an description to Interrupts, and then for each
item, just say that for gp0 cannot be dev_rdy, aka:
interrupts:
description:
The interrupt pins are digital outputs that can be configured at runtime
as multiple interrupt signals. Each can be configured as GP_INTR, RDY,
DEV_EN, logic low, logic high and DEV_RDY (GP1 only). RDY is the
active-low data ready signal, indicates when new ADC data are ready to
read. DEV_EN synchronizes the enable and power-down states of signal
chain devices with the ADC sampling instant. DEV_RDY is an active-high
signal that indicates when the device is ready to accept serial interface
communications. In GP_INTR mode, the interrupt outputs one of the
threshold detection interrupt signals (MIN_INTR, MAX_INTR or either).
minItems: 1
items:
- description:
gp0, interrupt line for GP0 pin, cannot be configured as DEV_RDY.
- description:
gp1, interrupt line for GP1 pin, can be configured to any setting.
interrupt-names:
items:
- const: gp0
- const: gp1
>
> > +
> > + vdd-supply:
> > + description: Analog power supply.
> > +
> > + vio-supply:
> > + description: Digital interface logic power supply.
> > +
> > + ref-supply:
> > + description: |
> > + Reference voltage to set the ADC full-scale range. If not present,
> > + vdd-supply is used as the reference voltage.
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - vdd-supply
> > + - vio-supply
> > +
> > +allOf:
> > + - $ref: /schemas/i3c/i3c.yaml#
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > + i3c {
> > + #address-cells = <3>;
> > + #size-cells = <0>;
> > +
> > + ad4062: adc@0,2ee007c0000 {
>
> Remove the ad4062 label here, since there are no users.
Ack.
>
> Cheers,
> Conor.
>
> pw-bot: changes-requested
>
Best regards,
Jorge
> > + reg = <0x0 0x2ee 0x7c0000>;
> > + vdd-supply = <&vdd>;
> > + vio-supply = <&vio>;
> > + ref-supply = <&ref>;
> > +
> > + gp1-gpios = <&gpio0 0 GPIO_ACTIVE_HIGH>;
> > + gp0-gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>;
> > + interrupt-parent = <&gpio>;
> > + interrupts = <0 0 IRQ_TYPE_EDGE_RISING>,
> > + <0 1 IRQ_TYPE_EDGE_FALLING>;
> > + interrupt-names = "gp0", "gp1";
> > + };
> > + };
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index f090c2f6e63a0d255a025885cc4573f5802ef159..afbfaeba5387b9fbfa9bf1443a059c47dd596d45 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1400,6 +1400,12 @@ F: Documentation/devicetree/bindings/iio/adc/adi,ad4030.yaml
> > F: Documentation/iio/ad4030.rst
> > F: drivers/iio/adc/ad4030.c
> >
> > +ANALOG DEVICES INC AD4062 DRIVER
> > +M: Jorge Marques <jorge.marques@...log.com>
> > +S: Supported
> > +W: https://ez.analog.com/linux-software-drivers
> > +F: Documentation/devicetree/bindings/iio/adc/adi,ad4062.yaml
> > +
> > ANALOG DEVICES INC AD4080 DRIVER
> > M: Antoniu Miclaus <antoniu.miclaus@...log.com>
> > L: linux-iio@...r.kernel.org
> >
> > --
> > 2.49.0
> >
Powered by blists - more mailing lists