linux-kernel - RE: [PATCH v3 3/3] media: uvc: Add D436 and D555 cameras metadata support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MN2PR18MB2479A2A1FF7F921AD6E88C3D88FFA@MN2PR18MB2479.namprd18.prod.outlook.com>
Date: Sun, 26 Oct 2025 16:38:49 +0000
From: Yogev Modlin <yogev.modlin@...lsenseai.com>
To: Ricardo Ribalda <ribalda@...omium.org>
CC: Laurent Pinchart <laurent.pinchart@...asonboard.com>, Hans de Goede
	<hansg@...nel.org>, Mauro Carvalho Chehab <mchehab@...nel.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 3/3] media: uvc: Add D436 and D555 cameras metadata
 support

Yes I agree.
I will check if it's possible to detect all d4xx cameras and not to submit a patch for each camera.
For now I will appreciate if we can continue with the current patch for those cameras.

-----Original Message-----
From: Ricardo Ribalda <ribalda@...omium.org>
Sent: Friday, October 24, 2025 2:13 PM
To: Yogev Modlin <yogev.modlin@...lsenseai.com>
Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>; Hans de Goede <hansg@...nel.org>; Mauro Carvalho Chehab <mchehab@...nel.org>; linux-media@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] media: uvc: Add D436 and D555 cameras metadata support

[You don't often get email from ribalda@...omium.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

Hi Yogev

Thanks for the patch. Some minor nitpicks inlined.


BTW, is there a way to programmatically detect if a device is RealSense with D4XX metadata?

I am thinking that maybe all have a special entity id, or any other way besides vid/pid.

I am asking you this, because if you could find a way to identify the camera you could implement something like uvc_meta_detect_msxu:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/usb/uvc/uvc_metadata.c#n170
Instead of creating quirks for every model.


Regards!
On Fri, 24 Oct 2025 at 07:50, Yogev Modlin via B4 Relay <devnull+yogev.modlin.realsenseai.com@...nel.org> wrote:
>
> From: Yogev Modlin <yogev.modlin@...lsenseai.com>
>
> Add support for Intel RealSense D436 and D555 depth cameras metadata.
> These cameras use the D4XX metadata format for transmitting depth and
> sensor information.
>
> The D555 camera uses UVC protocol version 1.5, while the D436 uses an
> undefined protocol version. Both cameras require the D4XX metadata
> format flag to properly handle their metadata streams.

We ask the lsusb -v output for every quirk we add. Could you provide that?

Thanks!

>
> Signed-off-by: Yogev Modlin <yogev.modlin@...lsenseai.com>
> ---
>  drivers/media/usb/uvc/uvc_driver.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c
> b/drivers/media/usb/uvc/uvc_driver.c
> index dbdacc64ea6b..6f0053a78123 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -3223,6 +3223,24 @@ static const struct usb_device_id uvc_ids[] = {
>           .bInterfaceSubClass   = 1,
>           .bInterfaceProtocol   = 0,
>           .driver_info          = UVC_INFO_META(V4L2_META_FMT_D4XX) },
> +       /* Intel Realsense D555 Depth Camera */
> +       { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
> +                               | USB_DEVICE_ID_MATCH_INT_INFO,
> +         .idVendor             = 0x8086,
> +         .idProduct            = 0x0b56,
> +         .bInterfaceClass      = USB_CLASS_VIDEO,
> +         .bInterfaceSubClass   = 1,
> +         .bInterfaceProtocol   = UVC_PC_PROTOCOL_15,
> +         .driver_info          = UVC_INFO_META(V4L2_META_FMT_D4XX) },
> +       /* Intel Realsense D436 Camera */

The list is sorted by vid:pid

Please move the definition to the correct site.

> +       { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
> +                               | USB_DEVICE_ID_MATCH_INT_INFO,
> +         .idVendor             = 0x8086,
> +         .idProduct            = 0x1156,
> +         .bInterfaceClass      = USB_CLASS_VIDEO,
> +         .bInterfaceSubClass   = 1,
> +         .bInterfaceProtocol   = UVC_PC_PROTOCOL_UNDEFINED,
> +         .driver_info          = UVC_INFO_META(V4L2_META_FMT_D4XX) },
>         /* Generic USB Video Class */
>         { USB_INTERFACE_INFO(USB_CLASS_VIDEO, 1, UVC_PC_PROTOCOL_UNDEFINED) },
>         { USB_INTERFACE_INFO(USB_CLASS_VIDEO, 1, UVC_PC_PROTOCOL_15)
> },
>
> --
> 2.43.0
>
>
>


--
Ricardo Ribalda