linux-kernel - Re: [PATCH] arm64: dts: rockchip: Fix vccio4-supply on rk3566-pinetab2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2caefd1-9668-0404-598f-98b26375525c@manjaro.org>
Date: Sun, 26 Oct 2025 18:36:15 +0100
From: "Dragan Simic" <dsimic@...jaro.org>
To: "Diederik de Haas" <diederik@...ow-tech.com>
Cc: "Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>, "Heiko Stuebner" <heiko@...ech.de>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, "Johan Jonker" <jbx6244@...il.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Fix vccio4-supply on rk3566-pinetab2

Hello Diederik,

On Sunday, October 26, 2025 18:25 CET, Diederik de Haas <diederik@...ow-tech.com> wrote:
> Page 13 of the PineTab2 v2 schematic dd 20230417 shows VCCIO4's power
> source is VCCIO_WL. Page 19 shows that VCCIO_WL is connected to
> VCCA1V8_PMU, so fix the PineTab2 dtsi to reflect that.
> 
> Signed-off-by: Diederik de Haas <diederik@...ow-tech.com>

Thanks for this patch.  As already discussed in private, this is
correct and safe to do, because both supplies are designated as
always-on, so please feel free to include:

Reviewed-by: Dragan Simic <dsimic@...jaro.org>

Though, I think this cleanup should also be propagated into the
stable kernels.  Right now this patch doesn't actually introduce
any functional changes, but maybe in the future there will be
some related driver or DT changes or improvements that may end up
relying on DT correction such as this one.

> ---
>  arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
> index d0e38412d56a..08bf40de17ea 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi
> @@ -789,7 +789,7 @@ &pmu_io_domains {
>  	vccio1-supply = <&vccio_acodec>;
>  	vccio2-supply = <&vcc_1v8>;
>  	vccio3-supply = <&vccio_sd>;
> -	vccio4-supply = <&vcc_1v8>;
> +	vccio4-supply = <&vcca1v8_pmu>;
>  	vccio5-supply = <&vcc_1v8>;
>  	vccio6-supply = <&vcc1v8_dvp>;
>  	vccio7-supply = <&vcc_3v3>;