linux-kernel - Re: [PATCH v5 2/4] media: imx8mq-mipi-csi2: Add output filed in csi2_pix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251026222826.GJ13023@pendragon.ideasonboard.com>
Date: Mon, 27 Oct 2025 00:28:26 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Frank Li <Frank.li@....com>
Cc: Guoniu Zhou <guoniu.zhou@....com>, Rui Miguel Silva <rmfrfs@...il.com>,
	Martin Kepplinger <martink@...teo.de>,
	Purism Kernel Team <kernel@...i.sm>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, linux-media@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/4] media: imx8mq-mipi-csi2: Add output filed in
 csi2_pix_format

On Wed, Aug 20, 2025 at 10:31:25AM -0400, Frank Li wrote:
> On Wed, Aug 20, 2025 at 07:04:57PM +0800, Guoniu Zhou wrote:
> > Add output filed in csi2_pix_format since the format on the
> > source pad might change due to unpacking.
> 
> Nit: wrap at 75 chars position
> 
> Add output filed in csi2_pix_format since the format on the source pad

s/filed/field/

> might change due to unpacking.
> 
> Treat 0 as meaning the output uses the same format as the input.
> 
> Reviewed-by: Frank Li <Frank.Li@....com>
> 
> > Signed-off-by: Guoniu Zhou <guoniu.zhou@....com>
> > ---
> >  drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> > index 85700655ecad334c61e9b5f9f073e10b6db2618f..ad7adc677e389e0f35b0cf63195279e197907f8c 100644
> > --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> > +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> > @@ -139,6 +139,7 @@ struct csi_state {
> >

A kerneldoc block would be good here to document the fields, it's not
very clear from the name what the output field is.

> >  struct csi2_pix_format {
> >  	u32 code;
> > +	u32 output;
> >  };
> >
> >  /* -----------------------------------------------------------------------------
> > @@ -634,6 +635,9 @@ static int imx8mq_mipi_csi_set_fmt(struct v4l2_subdev *sd,
> >  	fmt = v4l2_subdev_state_get_format(sd_state, MIPI_CSI2_PAD_SOURCE);
> >  	*fmt = sdformat->format;
> >
> > +	/* The format on the source pad might change due to unpacking. */
> > +	fmt->code = csi2_fmt->output ? : csi2_fmt->code;
> > +
> >  	return 0;
> >  }
> >

-- 
Regards,

Laurent Pinchart