linux-kernel - Re: [PATCH v2] nvmem: layouts: u-boot-env: add optional "env-size" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <176151779689.3048651.370574318472729306.robh@kernel.org>
Date: Sun, 26 Oct 2025 17:30:00 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Jascha Sundaresan <flizarthanon@...il.com>
Cc: Rafał Miłecki <rafal@...ecki.pl>,
	devicetree@...r.kernel.org, Conor Dooley <conor+dt@...nel.org>,
	Srinivas Kandagatla <srini@...nel.org>,
	linux-kernel@...r.kernel.org,
	Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH v2] nvmem: layouts: u-boot-env: add optional "env-size"
 property


On Thu, 23 Oct 2025 03:07:41 +0400, Jascha Sundaresan wrote:
> Some devices reserve a larger NVMEM region for the U-Boot environment
> than the actual environment data length used by U-Boot itself. The CRC32
> in the U-Boot header is calculated over the smaller data length, causing
> CRC validation to fail when Linux reads the full partition.
> 
> Allow an optional device tree property "env-size" to specify the
> environment data size to use for CRC computation.
> 
> v2: add missing $ref line to DT binding
> 
> Signed-off-by: Jascha Sundaresan <flizarthanon@...il.com>
> ---
> Changes in v2:
>  - Added missing "$ref" line to schema for env-size
>  - Confirmed dt_binding_check passes
> 
>  .../devicetree/bindings/nvmem/layouts/u-boot,env.yaml      | 7 +++++++
>  drivers/nvmem/layouts/u-boot-env.c                         | 4 +++-
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>