linux-kernel - Re: [PATCH v4 1/2] dt-bindings: phy: google: Add Google Tensor G5 USB PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e4c8875-10bc-4f4c-a675-a7cefc68c863@kernel.org>
Date: Mon, 27 Oct 2025 15:02:48 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Roy Luo <royluo@...gle.com>
Cc: Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I
 <kishon@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>,
 Peter Griffin <peter.griffin@...aro.org>,
 André Draszik <andre.draszik@...aro.org>,
 Tudor Ambarus <tudor.ambarus@...aro.org>,
 Joy Chakraborty <joychakr@...gle.com>, Naveen Kumar <mnkumar@...gle.com>,
 Badhri Jagan Sridharan <badhri@...gle.com>, linux-phy@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: phy: google: Add Google Tensor G5 USB
 PHY

On 24/10/2025 00:22, Roy Luo wrote:
>>> +
>>> +  clocks:
>>> +    items:
>>> +      - description: USB2 PHY clock.
>>> +      - description: USB2 PHY APB clock.
>>> +
>>> +  clock-names:
>>> +    items:
>>> +      - const: usb2_phy
>>
>> core
>>
>>> +      - const: u2phy_apb
>>
>> apb
>>
> 
> Just to provide the full context, these two clocks/resets
> (usb2_phy and u2phy_apb) are specifically for eUSB2 PHY.
> USB3/DP combo PHY has its own clock/reset that hasn't
> been added yet, we would have to differentiate them once

That's confusing a bit. You must add all clocks, all resets, all power
domains, all pins etc. Bindings are supposed to be complete, see writing
bindings doc.


Best regards,
Krzysztof