linux-kernel - Re: [PATCH v1] iio: adc: clear reference voltage bits before configuring vref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251027140759.3d3149bd@jic23-huawei>
Date: Mon, 27 Oct 2025 14:07:59 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Billy Tsai <billy_tsai@...eedtech.com>
Cc: <dlechner@...libre.com>, <nuno.sa@...log.com>, <andy@...nel.org>,
 <joel@....id.au>, <andrew@...econstruct.com.au>,
 <linux-iio@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
 <linux-aspeed@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] iio: adc: clear reference voltage bits before
 configuring vref

On Tue, 21 Oct 2025 13:39:18 +0800
Billy Tsai <billy_tsai@...eedtech.com> wrote:

> Ensures the reference voltage bits are cleared in the ADC engine
> control register before configuring the voltage reference. This
> avoids potential misconfigurations caused by residual bits.
> 
> Change-Id: I03c036436f376ced8a19fa5d407b7bbb377ae721
> Signed-off-by: Billy Tsai <billy_tsai@...eedtech.com>
Make sure the patch title includes the part/driver name.

iio: adc: aspeed: ..

+ the stuff Andy raised already.

Actual change looks correct to me.

> ---
>  drivers/iio/adc/aspeed_adc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c
> index 1d5fd5f534b8..8ab29948214a 100644
> --- a/drivers/iio/adc/aspeed_adc.c
> +++ b/drivers/iio/adc/aspeed_adc.c
> @@ -415,6 +415,7 @@ static int aspeed_adc_vref_config(struct iio_dev *indio_dev)
>  	}
>  	adc_engine_control_reg_val =
>  		readl(data->base + ASPEED_REG_ENGINE_CONTROL);
> +	adc_engine_control_reg_val &= ~ASPEED_ADC_REF_VOLTAGE;
>  
>  	ret = devm_regulator_get_enable_read_voltage(data->dev, "vref");
>  	if (ret < 0 && ret != -ENODEV)