linux-kernel - Re: [PATCH next] iio: imu: inv_icm45600: Add a missing return statement in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251027142331.29725dfe@jic23-huawei>
Date: Mon, 27 Oct 2025 14:23:31 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Remi Buisson <remi.buisson@....com>, David Lechner
 <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] iio: imu: inv_icm45600: Add a missing return
 statement in probe()

On Wed, 22 Oct 2025 14:02:20 +0300
Dan Carpenter <dan.carpenter@...aro.org> wrote:

> The intention here was clearly to return -ENODEV but the return statement
> was missing.  It would result in an off by one read in i3c_chip_info[] on
> the next line.  Add the return statement.
> 
> Fixes: 1bef24e9007e ("iio: imu: inv_icm45600: add I3C driver for inv_icm45600 driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/iio/imu/inv_icm45600/inv_icm45600_i3c.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/inv_icm45600/inv_icm45600_i3c.c b/drivers/iio/imu/inv_icm45600/inv_icm45600_i3c.c
> index b5df06b97d44..9247eae9b3e2 100644
> --- a/drivers/iio/imu/inv_icm45600/inv_icm45600_i3c.c
> +++ b/drivers/iio/imu/inv_icm45600/inv_icm45600_i3c.c
> @@ -57,7 +57,8 @@ static int inv_icm45600_i3c_probe(struct i3c_device *i3cdev)
>  	}
>  
>  	if (chip == nb_chip)
> -		dev_err_probe(&i3cdev->dev, -ENODEV, "Failed to match part id %d\n", whoami);
> +		return dev_err_probe(&i3cdev->dev, -ENODEV,
> +				     "Failed to match part id %d\n", whoami);
>  
>  	return inv_icm45600_core_probe(regmap, i3c_chip_info[chip], false, NULL);
>  }

I'm going to apply this but the resulting code is still wrong (even if not
a true bug after this fix).

A hard ID match like this breaks use of dt fallback compatibles.
What this should do is 'give it a go' on matching, but if there no match it should
carry on as if the match was to whatever the compatible that was supplied was.
When that happens a dev_info() is appropriate but not error out as this does.

Remi, if possible could you look at adding such a patch on top of this?

Thanks,

Jonathan