linux-kernel - Re: [PATCH v17 1/9] dt-bindings: pwm: add IPQ6018 binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <r7revm7tle6nh6kggf2kjwdz2pnpfdrn7web4ckqcbkorjodkq@ujl5mfh5eous>
Date: Mon, 27 Oct 2025 11:39:17 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: george.moussalem@...look.com
Cc: Uwe Kleine-König <ukleinek@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Baruch Siach <baruch@...s.co.il>, 
	Konrad Dybcio <konradybcio@...nel.org>, linux-arm-msm@...r.kernel.org, linux-pwm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Devi Priya <quic_devipriy@...cinc.com>, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	Baruch Siach <baruch.siach@...lu.com>
Subject: Re: [PATCH v17 1/9] dt-bindings: pwm: add IPQ6018 binding

On Wed, Oct 08, 2025 at 07:32:53PM +0400, George Moussalem via B4 Relay wrote:
> From: Devi Priya <quic_devipriy@...cinc.com>
> 
> DT binding for the PWM block in Qualcomm IPQ6018 SoC.
> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Co-developed-by: Baruch Siach <baruch.siach@...lu.com>
> Signed-off-by: Baruch Siach <baruch.siach@...lu.com>
> Signed-off-by: Devi Priya <quic_devipriy@...cinc.com>

Thanks for your work on this, George.

We need your Signed-off-by here as well though.

How about squashing the later additions to this same file, to avoid
repeatedly changing the file you introduce here, in this same series?
You can document your contribution by adding a line [george: Added
compatibles for X, Y, Z] before your signed-off-by.

Regards,
Bjorn

> ---
>  .../devicetree/bindings/pwm/qcom,ipq6018-pwm.yaml  | 44 ++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/qcom,ipq6018-pwm.yaml b/Documentation/devicetree/bindings/pwm/qcom,ipq6018-pwm.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..1172f0b53fadc140482f9384a36020260df372b7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/qcom,ipq6018-pwm.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/qcom,ipq6018-pwm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm IPQ6018 PWM controller
> +
> +maintainers:
> +  - Baruch Siach <baruch@...s.co.il>
> +
> +properties:
> +  compatible:
> +    const: qcom,ipq6018-pwm
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  "#pwm-cells":
> +    const: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - "#pwm-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/qcom,gcc-ipq6018.h>
> +
> +    pwm: pwm@...1010 {
> +        compatible = "qcom,ipq6018-pwm";
> +        reg = <0x01941010 0x20>;
> +        clocks = <&gcc GCC_ADSS_PWM_CLK>;
> +        assigned-clocks = <&gcc GCC_ADSS_PWM_CLK>;
> +        assigned-clock-rates = <100000000>;
> +        #pwm-cells = <2>;
> +    };
> 
> -- 
> 2.51.0
> 
>