linux-kernel - Re: [PATCH] arm64: dts: qcom: lemans-evk: Add RTC node for PMM8654AU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <kdufgqkfpe6sw2bpcxe3yjihj5hpsyilk7sid6ndyyukq5ozwc@sj7zphcrgjc4>
Date: Mon, 27 Oct 2025 12:28:54 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Rakesh Kota <rakesh.kota@....qualcomm.com>
Cc: Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: lemans-evk: Add RTC node for PMM8654AU

On Wed, Oct 15, 2025 at 07:12:34PM +0530, Rakesh Kota wrote:
> Add the RTC peripheral node for the PMM8654AU PMIC,
> which is controlled via the SPMI bus.
> 
> Signed-off-by: Rakesh Kota <rakesh.kota@....qualcomm.com>

Subject says this is for the EVK, but patch changes the generic Lemans
PMIC definitions.

> ---
>  arch/arm64/boot/dts/qcom/lemans-pmics.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
> index 1369c3d43f866de9d8cd5cd4985241b99c0a0454..4eda7043b851f363d0bf053587fb1f5edae0c4cd 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
> @@ -142,6 +142,13 @@ pmm8654au_0_gpios: gpio@...0 {
>  			#interrupt-cells = <2>;
>  		};
>  
> +		pmm8654au_0_rtc: rtc@...0 {

6100 < 8800 so this should be one step up.


But, then it won't merge, because
https://lore.kernel.org/all/20251017-add-rtc-for-lemans-v2-1-0aaf174b25b9@oss.qualcomm.com/
already added the RTC node there.

In other words, please search lore.kernel.org before posting patches, to
avoid sending the same patch multiple times.

Thank you,
Bjorn

> +			compatible = "qcom,pmk8350-rtc";
> +			reg = <0x6100>, <0x6200>;
> +			reg-names = "rtc", "alarm";
> +			interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>;
> +		};
> +
>  		pmm8654au_0_sdam_0: nvram@...0 {
>  			compatible = "qcom,spmi-sdam";
>  			reg = <0x7100>;
> 
> ---
> base-commit: 13863a59e410cab46d26751941980dc8f088b9b3
> change-id: 20251015-add_rtc_node-13490b702486
> 
> Best regards,
> -- 
> Rakesh Kota <rakesh.kota@....qualcomm.com>
>