linux-kernel - Re: [PATCH v5] memory: tegra210: Support interconnect framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALHNRZ9ZG2Vck4GB4an8-p-m39G2+YGffzOg630Ey6A6MHaCuA@mail.gmail.com>
Date: Mon, 27 Oct 2025 12:26:52 -0500
From: Aaron Kling <webgeek1234@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, 
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH v5] memory: tegra210: Support interconnect framework

On Mon, Oct 27, 2025 at 5:52 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 22/10/2025 05:10, Aaron Kling via B4 Relay wrote:
> > From: Aaron Kling <webgeek1234@...il.com>
> >
> > This makes mc and emc interconnect providers and allows for dynamic
> > memory clock scaling.
> >
> > Signed-off-by: Aaron Kling <webgeek1234@...il.com>
> > ---
> > Changes in v5:
> > - Split series
> > - Link to v4: https://lore.kernel.org/r/20250923-t210-actmon-v4-0-442d1eb6377c@gmail.com
> >
>
>
> Tried to apply... and see you did not run checkpatch.
>
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.

I ran b4 prep --check, which runs checkpatch and that passes. And none
of the kernel ci bots have complained. Normal checkpatch also passes.
If I run strict, I get a warning like the following:

#340: FILE: drivers/memory/tegra/tegra210-emc-core.c:2226:
+       if (!err) {
[...]
+       } else if (err != -ENODEV)
[...]

The code flow should be correct here. Is this what you are referring
to or are you getting an error/warning I'm not seeing?

Aaron