linux-kernel - Re: [PATCH v2] arm64: dts: rockchip: Harmonize regulator formatting for Pine64 rk3566 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60a1046c-437e-400a-8e2c-391cd471c358@kwiboo.se>
Date: Mon, 27 Oct 2025 19:06:12 +0100
From: Jonas Karlman <jonas@...boo.se>
To: Diederik de Haas <diederik@...ow-tech.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Dragan Simic <dsimic@...jaro.org>, Johan Jonker <jbx6244@...il.com>
Subject: Re: [PATCH v2] arm64: dts: rockchip: Harmonize regulator formatting
 for Pine64 rk3566 devices

Hi Diederik,

On 10/27/2025 4:39 PM, Diederik de Haas wrote:
> The regulator node properties in Pine64 rk3566 devices were formatted
> rather inconsistently. To name a few:
> - 'name' was sometimes put at the top of the list, while at other times
>   it was (mostly) sorted in alphabetical order

Personally I prefer to list the regulator-name as the first property, I
think it makes it visually easier/quicker to identify a regulator with
the name prop at top.

I typically try to use the following prop ordering for regulators on
board DTs I submit (and review):

- regulator-name as the first prop (to quickly identify the regulator)
- regulator-min-* before regulator-max-* (natural order)
- regulator-* in alphabetical/natural order

Maybe this preference just comes from a long history of always putting
id/primary key/unique identifiers at top or beginning of data tables,
classes, structs etc ;-)

Regards,
Jonas

> - 'always-on' and 'boot-on' were sometimes at the top of the list,
>   sometimes not
> - 'state-mem' nodes sometimes had a preceding blank line, as they
>   should, but sometimes not
> - other properties seem to have been added to the end of the list, not
>   in their alphabetical/natural order
> 
> So harmonize the formatting by making all properties sorted
> alphabetically/naturally. And harmonize the formatting of the
> 'state-mem' nodes so they all have a preceding blank line. While at it,
> also fix 2 incorrectly indented nodes.
> 
> No functional changes.
> 
> Signed-off-by: Diederik de Haas <diederik@...ow-tech.com>
> ---
> No outright NACKs and one positive response (thanks!), so here's v2.
> 
> Changes in v2:
> - Found more regulators at the beginning of the pinetab2 dtsi file
> - Missed a 'regulator-always-on' on regulator-vcc3v3-sys in q64b dts
> Link to v1:
> https://lore.kernel.org/all/20251026153805.107774-1-diederik@cknow-tech.com/

[snip]