linux-kernel - Re: [PATCH 1/2] dt-bindings: nvmem: lan9662-otpc: Add LAN969x series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251027182248.GA1281416-robh@kernel.org>
Date: Mon, 27 Oct 2025 13:22:48 -0500
From: Rob Herring <robh@...nel.org>
To: Robert Marko <robert.marko@...tura.hr>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, srini@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org,
	horatiu.vultur@...rochip.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, daniel.machon@...rochip.com,
	luka.perkov@...tura.hr
Subject: Re: [PATCH 1/2] dt-bindings: nvmem: lan9662-otpc: Add LAN969x series

On Mon, Oct 27, 2025 at 01:23:20PM +0100, Robert Marko wrote:
> On Sun, Oct 26, 2025 at 11:10 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >
> > On 24/10/2025 21:24, Robert Marko wrote:
> > > LAN969x series also has the same HW block, its just 16KB instead of 8KB
> > > like on LAN966x series.
> > >
> > > So, document compatibles for the LAN969x series.
> > >
> > > Signed-off-by: Robert Marko <robert.marko@...tura.hr>
> > > ---
> > >  .../devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml  | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml b/Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml
> > > index f97c6beb4766..f8c68cf22c1c 100644
> > > --- a/Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml
> > > +++ b/Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml
> > > @@ -23,8 +23,15 @@ properties:
> > >        - items:
> > >            - const: microchip,lan9668-otpc
> > >            - const: microchip,lan9662-otpc
> > > +          - const: microchip,lan9691-otpc
> > > +          - const: microchip,lan9692-otpc
> > > +          - const: microchip,lan9693-otpc
> > > +          - const: microchip,lan9694-otpc
> > > +          - const: microchip,lan9696-otpc
> > > +          - const: microchip,lan9698-otpc
> >
> > Why are you changing lan9668? Nothing on this is explained in commit
> > msg. Also, list of more than 3 items is not really useful.
> 
> I am not chaning lan9668 but rather lan9698.
> I agree that a list of all possible SoC models is not ideal but I was
> just following the current
> style in the binding.
> 
> As far as I know, the whole LAN969x series has identical OTP so just
> using a single
> microchip,lan9691-otpc compatible is enough.

The above is a *list* of what a "compatible" entry must contain.

> 
> >
> > >        - enum:
> > >            - microchip,lan9662-otpc
> > > +          - microchip,lan9691-otpc

"enum" on the other hand is a list of possible values for 1 entry in 
"compatible".

Rob