linux-kernel - Re: [PATCH 2/2] gpu: nova: add boot42 support for next-gen GPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251027212133.GA298309@joelbox2>
Date: Mon, 27 Oct 2025 17:21:33 -0400
From: Joel Fernandes <joelagnelf@...dia.com>
To: John Hubbard <jhubbard@...dia.com>
Cc: Danilo Krummrich <dakr@...nel.org>,
	Alexandre Courbot <acourbot@...dia.com>,
	Timur Tabi <ttabi@...dia.com>, Alistair Popple <apopple@...dia.com>,
	Edwin Peer <epeer@...dia.com>, Zhi Wang <zhiw@...dia.com>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <lossin@...nel.org>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	nouveau@...ts.freedesktop.org, rust-for-linux@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] gpu: nova: add boot42 support for next-gen GPUs

On Sat, Oct 25, 2025 at 10:32:35AM -0700, John Hubbard wrote:
> On 10/25/25 3:01 AM, Danilo Krummrich wrote:
> > On Sat Oct 25, 2025 at 2:14 AM CEST, John Hubbard wrote:
> ...> Why open code all of the above in the struct Gpu constructor? This
> could all
> > happen within Spec::new().
> > 
> 
> OK, yes, that does help avoid cluttering up Gpu::new().

+1.
Also, it bloats up the dev_info! print in Gpu::new() to those.
Spec can encapsulate the boot0 vs boot42 code, and any further changes.

But otherwise, the boot0 vs boot42 code in the patchset look good to me.

thanks,

 - Joel