linux-kernel - Re: [PATCH v6 2/9] dt-bindings: fsl,fpga-qixis-i2c: add support for LX2160ARDB FPGA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aP8P9bUcVki_wIbG@dragon>
Date: Mon, 27 Oct 2025 14:23:49 +0800
From: Shawn Guo <shawnguo2@...h.net>
To: Ioana Ciornei <ioana.ciornei@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Shawn Guo <shawnguo@...nel.org>, Michael Walle <mwalle@...nel.org>,
	devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, Frank Li <Frank.Li@....com>,
	Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH v6 2/9] dt-bindings: fsl,fpga-qixis-i2c: add support for
 LX2160ARDB FPGA

On Tue, Oct 14, 2025 at 06:53:51PM +0300, Ioana Ciornei wrote:
> Extend the list of supported compatible strings with fsl,lx2160ardb-fpga.
> 
> Since the register map exposed by the LX2160ARDB's FPGA also contains
> two GPIO controllers, accept the necessary GPIO pattern property.
> At the same time, add the #address-cells and #size-cells properties as
> valid ones so that the child nodes of the fsl,lx2160ardb-fpga node are
> addressable.
> 
> This is necessary because when defining child devices such as the GPIO
> controller described in the added example, the child device needs a the
> reg property to properly identify its register location in the parent
> I2C device address space.
> 
> Impose this restriction for the new compatible through an if-statement.
> 
> The feature set exposed by these QIXIS FPGA devices is highly dependent
> on the board type, meaning that even though the FPGA found on the
> LX2160AQDS board (fsl,lx2160aqds-fpga) works in the same way in terms of
> access over I2C as the one found on the LX2160ARDB (fsl,lx2160ardb-fpga
> added here), the register map inside the device space is different since
> there are different on-board devices to be controlled.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Applied, thanks!