linux-kernel - Re: [PATCH v5 5/5] vfio: selftests: add end of address space DMA map/unmap tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aQAEGNLbiCFhq-LG@google.com>
Date: Mon, 27 Oct 2025 23:45:28 +0000
From: David Matlack <dmatlack@...gle.com>
To: Alex Mastro <amastro@...com>
Cc: Alex Williamson <alex@...zbot.org>, Jason Gunthorpe <jgg@...pe.ca>,
	Alejandro Jimenez <alejandro.j.jimenez@...cle.com>,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 5/5] vfio: selftests: add end of address space DMA
 map/unmap tests

On 2025-10-27 10:33 AM, Alex Mastro wrote:
> Add tests which validate dma map/unmap at the end of address space. Add
> negative test cases for checking that overflowing ioctl args fail with
> the expected errno.
> 
> Signed-off-by: Alex Mastro <amastro@...com>

Reviewed-by: David Matlack <dmatlack@...gle.com>

> +FIXTURE_SETUP(vfio_dma_map_limit_test)
> +{
> +	u64 region_size = getpagesize();

nit: Add a blank line after variable declarations.

> +	/*
> +	 * Over-allocate mmap by double the size to provide enough backing vaddr
> +	 * for overflow tests
> +	 */
> +	self->mmap_size = 2 * region_size;
> +	struct vfio_dma_region *region = &self->region;

nit: Declare variables at the beginning of blocks.