linux-kernel - Re: [PATCH v3 4/4] io_uring/uring_cmd: avoid double indirect call in task work dispatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251027075142.GA14661@lst.de>
Date: Mon, 27 Oct 2025 08:51:42 +0100
From: Christoph Hellwig <hch@....de>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: Jens Axboe <axboe@...nel.dk>, Miklos Szeredi <miklos@...redi.hu>,
	Ming Lei <ming.lei@...hat.com>, Keith Busch <kbusch@...nel.org>,
	Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
	Chris Mason <clm@...com>, David Sterba <dsterba@...e.com>,
	io-uring@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-block@...r.kernel.org, linux-nvme@...ts.infradead.org,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/4] io_uring/uring_cmd: avoid double indirect call
 in task work dispatch

> +static void blk_cmd_complete(struct io_tw_req tw_req, io_tw_token_t tw)
>  {
> +	unsigned int issue_flags = IO_URING_CMD_TASK_WORK_ISSUE_FLAGS;

In most of these ioctl handlers issue_flags only has a single user,
so you might as well pass it directly.

In fact asm most external callers of io_uring_cmd_done pass that, would
a helper that just harcodes it make sense and then maybe switch the
special cases to use __io_uring_cmd_done directly?