linux-kernel - Re: [PATCH v3 17/31] media: synopsys: move imx6-mipi-csi2.c to synopsys/mipi-csi2.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aP83D-ndmlv5Jns8@valkosipuli.retiisi.eu>
Date: Mon, 27 Oct 2025 11:10:39 +0200
From: Sakari Ailus <sakari.ailus@....fi>
To: Frank Li <Frank.Li@....com>
Cc: Rui Miguel Silva <rmfrfs@...il.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Martin Kepplinger <martink@...teo.de>,
	Purism Kernel Team <kernel@...i.sm>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Eugen Hristev <eugen.hristev@...aro.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, Peng Fan <peng.fan@....com>,
	Alice Yuan <alice.yuan@....com>, Vinod Koul <vkoul@...nel.org>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Steve Longerbeam <slongerbeam@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-media@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-phy@...ts.infradead.org,
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH v3 17/31] media: synopsys: move imx6-mipi-csi2.c to
 synopsys/mipi-csi2.c

Hi Frank,

On Thu, Aug 21, 2025 at 04:15:52PM -0400, Frank Li wrote:
> Move dw MIPI CSI2 common part drivers/staging/media/imx/imx6-mipi-csi2.c
> under synopsys to let more SoC can reuse it.
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  drivers/media/platform/synopsys/Kconfig                      | 12 ++++++++++++
>  drivers/media/platform/synopsys/Makefile                     |  2 ++
>  .../imx6-mipi-csi2.c => media/platform/synopsys/mipi-csi2.c} |  0
>  drivers/staging/media/imx/Kconfig                            |  1 +
>  drivers/staging/media/imx/Makefile                           |  2 +-
>  5 files changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/synopsys/Kconfig b/drivers/media/platform/synopsys/Kconfig
> index 4fd521f78425a96985fa3b6b017deef36631d1a9..e54dad835349d420dead6d5313c0623567c28c0b 100644
> --- a/drivers/media/platform/synopsys/Kconfig
> +++ b/drivers/media/platform/synopsys/Kconfig
> @@ -1,3 +1,15 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  
> +config VIDEO_SYNOPSYS_MIPI_CSI2
> +        tristate "Synopsys DesignWare MIPI CSI2 Receiver common library"
> +        depends on VIDEO_DEV
> +        select MEDIA_CONTROLLER
> +        select VIDEO_V4L2_SUBDEV_API
> +        select VIDEOBUF2_DMA_CONTIG
> +        help
> +          Common library for MIPI CSI2 Controller.
> +
> +          To compile this driver as a module, choose M here. The module
> +          will be called synopsys_hdmirx
> +
>  source "drivers/media/platform/synopsys/hdmirx/Kconfig"
> diff --git a/drivers/media/platform/synopsys/Makefile b/drivers/media/platform/synopsys/Makefile
> index 3b12c574dd67c072901108d88cad64ca3a723938..045ed3177738e6d28aa223804b79e6774e141dc8 100644
> --- a/drivers/media/platform/synopsys/Makefile
> +++ b/drivers/media/platform/synopsys/Makefile
> @@ -1,2 +1,4 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  obj-y += hdmirx/
> +
> +obj-$(CONFIG_VIDEO_SYNOPSYS_MIPI_CSI2) += mipi-csi2.o

Please give the module a more specific name.

> diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c b/drivers/media/platform/synopsys/mipi-csi2.c
> similarity index 100%
> rename from drivers/staging/media/imx/imx6-mipi-csi2.c
> rename to drivers/media/platform/synopsys/mipi-csi2.c
> diff --git a/drivers/staging/media/imx/Kconfig b/drivers/staging/media/imx/Kconfig
> index 1cd48028b6416ae16ed69c68186281b6c6bcbec8..53e5c1546ac53e4942974a9acdcf078de1cb6073 100644
> --- a/drivers/staging/media/imx/Kconfig
> +++ b/drivers/staging/media/imx/Kconfig
> @@ -10,6 +10,7 @@ config VIDEO_IMX_MEDIA
>  	select V4L2_MEM2MEM_DEV
>  	select VIDEOBUF2_DMA_CONTIG
>  	select VIDEO_V4L2_SUBDEV_API
> +	select VIDEO_SYNOPSYS_MIPI_CSI2
>  	help
>  	  Say yes here to enable support for video4linux media controller
>  	  drivers for the i.MX5/6 SOC.
> diff --git a/drivers/staging/media/imx/Makefile b/drivers/staging/media/imx/Makefile
> index 064a6c6c069aa440c72a483080cbedf89d370193..1978b82fd1876566acbb952a4d14cf9aca35e996 100644
> --- a/drivers/staging/media/imx/Makefile
> +++ b/drivers/staging/media/imx/Makefile
> @@ -11,4 +11,4 @@ imx6-media-csi-objs := imx-media-csi.o imx-media-fim.o
>  obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx-media-common.o
>  obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx6-media.o
>  obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx6-media-csi.o
> -obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx6-mipi-csi2.o imx6-csi2.o
> +obj-$(CONFIG_VIDEO_IMX_MEDIA) += imx6-csi2.o
> 

-- 
Regards,

Sakari Ailus