linux-kernel - Re: linux-next: build failure after merge of the pwm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DDT05KLECH04.37PKIHQQ4K3MX@kernel.org>
Date: Mon, 27 Oct 2025 10:38:05 +0100
From: "Danilo Krummrich" <dakr@...nel.org>
To: Uwe Kleine-König <ukleinek@...nel.org>
Cc: "Stephen Rothwell" <sfr@...b.auug.org.au>, "Michal Wilczynski"
 <m.wilczynski@...sung.com>, "Boqun Feng" <boqun.feng@...il.com>, "Daniel
 Almeida" <daniel.almeida@...labora.com>, "Peter Colberg"
 <pcolberg@...hat.com>, "Lyude Paul" <lyude@...hat.com>, "Miguel Ojeda"
 <ojeda@...nel.org>, "Linux Kernel Mailing List"
 <linux-kernel@...r.kernel.org>, "Linux Next Mailing List"
 <linux-next@...r.kernel.org>, "Alice Ryhl" <aliceryhl@...gle.com>, "Viresh
 Kumar" <viresh.kumar@...aro.org>, "Alexandre Courbot"
 <acourbot@...dia.com>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Subject: Re: linux-next: build failure after merge of the pwm tree

On Mon Oct 27, 2025 at 9:11 AM CET, Uwe Kleine-König wrote:
> Translating the changes that commit does to
> drivers/gpu/drm/nova/driver.rs for drivers/pwm/pwm_th1520.rs results in:
>
> diff --git a/drivers/pwm/pwm_th1520.rs b/drivers/pwm/pwm_th1520.rs
> index 0ad38b78be85..dd554574adc8 100644
> --- a/drivers/pwm/pwm_th1520.rs
> +++ b/drivers/pwm/pwm_th1520.rs
> @@ -328,7 +328,7 @@ impl platform::Driver for Th1520PwmPlatformDriver {
>      fn probe(
>          pdev: &platform::Device<Core>,
>          _id_info: Option<&Self::IdInfo>,
> -    ) -> Result<Pin<KBox<Self>>> {
> +    ) -> impl PinInit<Self, Error> {
>          let dev = pdev.as_ref();
>          let request = pdev.io_request_by_index(0).ok_or(ENODEV)?;
>  
> @@ -365,7 +365,7 @@ fn probe(
>  
>          pwm::Registration::register(dev, chip)?;
>  
> -        Ok(KBox::new(Th1520PwmPlatformDriver, GFP_KERNEL)?.into())
> +        Ok(Th1520PwmPlatformDriver)
>      }
>  }

Yes, this looks good.

Thanks,
Danilo