linux-kernel - Re: [PATCH] dma-fence: Fix safe access wrapper to call timeline name method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c91b3ed-258c-46e1-8bf2-50c70d982cf6@amd.com>
Date: Mon, 27 Oct 2025 11:27:02 +0100
From: Christian König <christian.koenig@....com>
To: Tvrtko Ursulin <tursulin@...ulin.net>, Akash Goel <akash.goel@....com>,
 sumit.semwal@...aro.org, gustavo@...ovan.org
Cc: linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org, nd@....com,
 stable@...r.kernel.org
Subject: Re: [PATCH] dma-fence: Fix safe access wrapper to call timeline name
 method

On 10/21/25 20:36, Tvrtko Ursulin wrote:
> 
> On 21/10/2025 17:09, Akash Goel wrote:
>> This commit fixes the wrapper function dma_fence_timeline_name(), that
>> was added for safe access, to actually call the timeline name method of
>> dma_fence_ops.
>>
>> Cc: <stable@...r.kernel.org> # v6.17+
>> Signed-off-by: Akash Goel <akash.goel@....com>
> 
> Fixes: 506aa8b02a8d ("dma-fence: Add safe access helpers and document the rules")
> 
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@...lia.com>

Good catch, Reviewed-by: Christian König <christian.koenig@....com> as well.

Please ping me if you need somebody to push this to drm-misc-fixes.

Thanks,
Christian.

> 
> Apologies for the copy and paste snafu.
> 
> Regards,
> 
> Tvrtko
> 
>> ---
>>   drivers/dma-buf/dma-fence.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
>> index 3f78c56b58dc..39e6f93dc310 100644
>> --- a/drivers/dma-buf/dma-fence.c
>> +++ b/drivers/dma-buf/dma-fence.c
>> @@ -1141,7 +1141,7 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence)
>>                "RCU protection is required for safe access to returned string");
>>         if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
>> -        return fence->ops->get_driver_name(fence);
>> +        return fence->ops->get_timeline_name(fence);
>>       else
>>           return "signaled-timeline";
>>   }
>