linux-kernel - Re: [PATCH for-next] RDMA/cm: Base cm_id destruction timeout on CMA values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251027113636.GI12554@unreal>
Date: Mon, 27 Oct 2025 13:36:36 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Håkon Bugge <haakon.bugge@...cle.com>
Cc: Jason Gunthorpe <jgg@...pe.ca>, Sean Hefty <shefty@...dia.com>,
	Vlad Dumitrescu <vdumitrescu@...dia.com>,
	Or Har-Toov <ohartoov@...dia.com>,
	Jacob Moroni <jmoroni@...gle.com>,
	Manjunath Patil <manjunath.b.patil@...cle.com>,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-next] RDMA/cm: Base cm_id destruction timeout on CMA
 values

On Tue, Oct 21, 2025 at 03:27:33PM +0200, Håkon Bugge wrote:
> When a GSI MAD packet is sent on the QP, it will potentially be
> retried CMA_MAX_CM_RETRIES times with a timeout value of:
> 
>     4.096usec * 2 ^ CMA_CM_RESPONSE_TIMEOUT
> 
> The above equates to ~64 seconds using the default CMA values.
> 
> The cm_id_priv's refcount will be incremented for this period.
> Therefore, the timeout value waiting for a cm_id destruction must be
> based on the effective timeout of MAD packets.  To provide additional
> leeway, we add 25% to this timeout and use that instead of the
> constant 10 seconds timeout, which may result in false negatives.
> 
> Fixes: 96d9cbe2f2ff ("RDMA/cm: add timeout to cm_destroy_id wait")

I applied and removed this Fixes line. Most likely someone will complain
that this patch breaks his flow.

Thanks