linux-kernel - Re: [PATCH] ocfs2: validate cl_bpc in ocfs2_block_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADhLXY7_NT4e8jV=CV0nA6wLFJcrokGV2dRfp_cUJmX7=UY5RA@mail.gmail.com>
Date: Mon, 27 Oct 2025 17:11:57 +0530
From: Deepanshu Kartikey <kartikey406@...il.com>
To: Joseph Qi <joseph.qi@...ux.alibaba.com>
Cc: mark@...heh.com, jlbec@...lplan.org, Heming Zhao <heming.zhao@...e.com>, 
	ocfs2-devel@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	syzbot+fd8af97c7227fe605d95@...kaller.appspotmail.com
Subject: Re: [PATCH] ocfs2: validate cl_bpc in ocfs2_block_group_alloc to
 prevent divide-by-zero

Hi Joseph,

Thank you for the review and suggestion!

You're absolutely right that moving the validation to
ocfs2_validate_inode_block()
would be cleaner and benefit all code paths. I'll revise the patch to add the
validation there, checking for OCFS2_CHAIN_FL before validating cl_bpc.

I'll send v2 shortly.

Thanks,
Deepanshu