linux-kernel - Re: [PATCH 0/2] Modify USB controller nodes for USB on X1E80100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22ad48ac-e054-4f2f-a5a5-8047266ff4cc@oss.qualcomm.com>
Date: Mon, 27 Oct 2025 12:46:46 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Krishna Kurapati PSSNV <krishna.kurapati@....qualcomm.com>,
        Val Packett <val@...kett.cool>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>, Abel Vesa <abel.vesa@...aro.org>,
        Rajendra Nayak <quic_rjendra@...cinc.com>,
        Sibi Sankar <sibi.sankar@....qualcomm.com>
Subject: Re: [PATCH 0/2] Modify USB controller nodes for USB on X1E80100

On 10/19/25 1:35 PM, Krishna Kurapati PSSNV wrote:
> 
> 
> On 10/14/2025 2:30 PM, Val Packett wrote:
>> Hi,
>>
>> On 10/13/25 11:21 PM, Krishna Kurapati wrote:
>>> This series aims to flatten usb dt nodes and use latest bindings.
>>> While at it, fix a compile time warning on the HS only controller node.
>>>
>>> Tests done:
>>> 1. On CRD, verified host mode operation of the 3 exposed Type-C ports
>>> and enumeration of the Goodix fingerprint sensor on the multiport
>>> usb controller.
>>>
>>> 2. Modified the dr_mode to otg for the first 3 controllers and
>>> verified role switching and device mode operation on the 3 exposed
>>> Type-C ports.
>>>
>>> HS only controller was not tested on any platform.
>>
>> have you tested suspend-resume?
>>
>> The flattened dwc driver seems to break it for me on Latitude 7455, upon trying to resume the screen never comes back up and the system just reboots from zero in a couple seconds instead.
>>
>> I've looked at the code and I couldn't find the cause so far, but it is fine with the legacy driver and not fine with this one :(
>>
> 
> Hi Val,
> 
>  Thanks for reporting this. I did test runtime suspend resume on all 3 typec ports as mentioned. But I didn't check system suspend case.
> 
>  I will try to reproduce the issue, fix it and then resend the patches.

I can repro on the CRD..

It's the USB3_0 host that causes the issue

Removing the clk_bulk_disable_unprepare() call in dwc3_qcom_suspend()
helps..

Konrad