linux-kernel - Re: [PATCH] arm64: dts: rockchip: orangepi-5: fix PCIe 3.3V regulator voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1499f50e-aa4f-454a-b8b5-c9a21bef7f72@collabora.com>
Date: Mon, 27 Oct 2025 13:39:02 +0100
From: Michael Riesch <michael.riesch@...labora.com>
To: Mykola Kvach <xakep.amatop@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 Cenk Uluisik <cenk.uluisik@...glemail.com>, Johan Jonker <jbx6244@...il.com>
Cc: Jimmy Hon <honyuenkwun@...il.com>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Muhammed Efe Cetin <efectn@...l.net>
Subject: Re: [PATCH] arm64: dts: rockchip: orangepi-5: fix PCIe 3.3V regulator
 voltage

Hi Mykola,

Thanks for your patch.

Cc: Muhammed who is the author of commit b6bc755d806e

On 10/24/25 19:38, Mykola Kvach wrote:
> The vcc3v3_pcie20 fixed regulator powers the PCIe device-side 3.3V
> rail for pcie2x1l2 via vpcie3v3-supply. The DTS mistakenly set its
> regulator-min/max-microvolt to 1800000. Correct both to 3300000
> to match the rail name, the PCIe/M.2 power requirement, and the
> actual hardware wiring on Orange Pi 5.
> 

I guess a "Fixes" tag is in order here:

Fixes: b6bc755d806e ("arm64: dts: rockchip: Add Orange Pi 5")

And make sure to Cc: <stable@...r.kernel.org>

> Signed-off-by: Mykola Kvach <xakep.amatop@...il.com>

The change itself makes sense to me.

Reviewed-by: Michael Riesch <michael.riesch@...labora.com>

Best regards,
Michael

> ---
>  arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> index ad6d04793b0a..83b9b6645a1e 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts
> @@ -14,8 +14,8 @@ vcc3v3_pcie20: regulator-vcc3v3-pcie20 {
>  		gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_HIGH>;
>  		regulator-name = "vcc3v3_pcie20";
>  		regulator-boot-on;
> -		regulator-min-microvolt = <1800000>;
> -		regulator-max-microvolt = <1800000>;
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
>  		startup-delay-us = <50000>;
>  		vin-supply = <&vcc5v0_sys>;
>  	};