linux-kernel - Re: [PATCH 3/4] iio: light: apds9306: convert to use maple tree register cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <301aff96-5565-47cf-b519-27234ea53ea8@tweaklogic.com>
Date: Mon, 27 Oct 2025 23:36:32 +1030
From: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>
To: Chu Guangqing <chuguangqing@...pur.com>, lars@...afoo.de,
 Michael.Hennerich@...log.com, jic23@...nel.org, dlechner@...libre.com,
 nuno.sa@...log.com, andy@...nel.org, javier.carrasco.cruz@...il.com
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] iio: light: apds9306: convert to use maple tree
 register cache

On 24/10/25 18:08, Chu Guangqing wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Chu Guangqing <chuguangqing@...pur.com>
> ---
>   drivers/iio/light/apds9306.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
> index 389125675caa..7e68cca0edfa 100644
> --- a/drivers/iio/light/apds9306.c
> +++ b/drivers/iio/light/apds9306.c
> @@ -350,7 +350,7 @@ static const struct regmap_config apds9306_regmap = {
>   	.volatile_table = &apds9306_volatile_table,
>   	.precious_table = &apds9306_precious_table,
>   	.max_register = APDS9306_ALS_THRES_VAR_REG,
> -	.cache_type = REGCACHE_RBTREE,
> +	.cache_type = REGCACHE_MAPLE,
>   };
>   
>   static const struct reg_field apds9306_rf_sw_reset =
Looks good. I will test it on a real hardware soon. Thank you.
Jonathan will know more about regmap internal implementations.

Acked-by: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>

Regards,
Subhajit Ghosh